public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mkretz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/77776] C++17 std::hypot implementation is poor Date: Mon, 04 Mar 2024 10:45:31 +0000 [thread overview] Message-ID: <bug-77776-4-NbvVrQMtS2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-77776-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77776 --- Comment #15 from Matthias Kretz (Vir) <mkretz at gcc dot gnu.org> --- Your implementation still needs to solve: 1. Loss of precision because of division & subsequent scaling by max. Users comparing std::hypot(x, y, z) against a simple std::sqrt(x * x + y * y + z * z) might wonder why they want to use std::hypot if it's less precise. 2. Relatively high cost (in latency and throughput) because of the three divisions. You could replace it with scale = 1/max; x *= scale; ... But that can reduce precision even further. 3. Summation of the x, y, and z squares isn't associative if you care about precision. A high quality implementation needs to add the two lowest values first. Here's a precise but inefficient implementation: (https://compiler-explorer.com/z/ocGPnsYE3) template <typename T> [[gnu::optimize("-fno-unsafe-math-optimizations")]] T hypot3(T x, T y, T z) { x = std::abs(x); y = std::abs(y); z = std::abs(z); if (std::isinf(x) || std::isinf(y) || std::isinf(z)) return std::__infinity_v<T>; else if (std::isnan(x) || std::isnan(y) || std::isnan(z)) return std::__quiet_NaN_v<T>; else if (x == y && y == z) return x * std::sqrt(T(3)); else if (z == 0 && y == 0) return x; else if (x == 0 && z == 0) return y; else if (x == 0 && y == 0) return z; else { T hi = std::max(std::max(x, y), z); T lo0 = std::min(std::max(x, y), z); T lo1 = std::min(x, y); int e = 0; hi = std::frexp(hi, &e); lo0 = std::ldexp(lo0, -e); lo1 = std::ldexp(lo1, -e); T lo = lo0 * lo0 + lo1 * lo1; return std::ldexp(std::sqrt(hi * hi + lo), e); } } AFAIK https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/include/experimental/bits/simd_math.h;h=06e7b4496f9917f886f66fbd7629700dd17e55f9;hb=HEAD#l1168 is a precise and efficient implementation. It also avoids division altogether unless an input is subnormal.
next prev parent reply other threads:[~2024-03-04 10:45 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-77776-4@http.gcc.gnu.org/bugzilla/> 2021-05-04 12:31 ` rguenth at gcc dot gnu.org 2024-02-29 18:23 ` g.peterhoff@t-online.de 2024-03-01 12:27 ` redi at gcc dot gnu.org 2024-03-02 15:52 ` g.peterhoff@t-online.de 2024-03-04 3:49 ` de34 at live dot cn 2024-03-04 10:45 ` mkretz at gcc dot gnu.org [this message] 2024-03-04 11:12 ` jakub at gcc dot gnu.org 2024-03-04 17:14 ` mkretz at gcc dot gnu.org 2024-03-04 20:21 ` jakub at gcc dot gnu.org 2024-03-06 2:47 ` g.peterhoff@t-online.de 2024-03-06 9:43 ` mkretz at gcc dot gnu.org 2024-03-06 12:35 ` redi at gcc dot gnu.org 2024-03-12 11:31 ` mkretz at gcc dot gnu.org 2024-03-19 0:09 ` g.peterhoff@t-online.de 2024-03-25 10:06 ` mkretz at gcc dot gnu.org 2024-04-05 1:08 ` g.peterhoff@t-online.de 2024-04-05 1:23 ` g.peterhoff@t-online.de 2024-04-10 16:41 ` g.peterhoff@t-online.de 2024-04-10 16:48 ` jakub at gcc dot gnu.org 2024-04-10 18:08 ` g.peterhoff@t-online.de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-77776-4-NbvVrQMtS2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).