public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "puetzk at puetzk dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/78100] DWARF symbols for an array sometimes missing the array length
Date: Sat, 01 Jun 2024 03:38:36 +0000	[thread overview]
Message-ID: <bug-78100-4-S1TYWyaPbw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-78100-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78100

Kevin Puetz <puetzk at puetzk dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |puetzk at puetzk dot org

--- Comment #6 from Kevin Puetz <puetzk at puetzk dot org> ---
Possibly r263660/ea379c9ec3776b9d4f72d5d8c8987e2e43c7baae? 
add_bound_info (subrange_die, DW_AT_upper_bound) eventually calls the
add_scalar_info() that was changed in that patch. And it at least seems
plausible that the changes around decl_die = lookup_decl_die(decl)` could be
relevant.

https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=gcc/dwarf2out.c;h=b80c909e1fc6b05c35faa30a72e262a08cc7d65e;hp=236f199afcf050957639f1cce839f870a0d472c6;hb=ea379c9ec3776b9d4f72d5d8c8987e2e43c7baae;hpb=3fb558b154f795983ae6a9dd6478e18a2c846584

The new code requires that decl_die have  DW_AT_location or DW_AT_const_value
in order to take the early return, and the first decl (the `extern` with
DW_AT_external = yes) has neither. So that would help the function *not* just
reference the extern and return early, thus eventually writing the complete
DW_TAG_array_type too.

I don't know this code well, haven't actually bisected, and this isn't actually
an LTO case that patch's comment describes... but it seems to be in the right
timeframe and changing relevant parts of dwarf2out.c

  parent reply	other threads:[~2024-06-01  3:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-78100-4@http.gcc.gnu.org/bugzilla/>
2024-01-05 17:56 ` gccbugs at dima dot secretsauce.net
2024-03-14 16:38 ` cJ-gcc at zougloub dot eu
2024-06-01  3:38 ` puetzk at puetzk dot org [this message]
2024-06-01  3:56 ` puetzk at puetzk dot org
2024-06-01  4:01 ` puetzk at puetzk dot org
2024-06-01 11:52 ` mark at gcc dot gnu.org
2024-06-01 13:33 ` puetzk at puetzk dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-78100-4-S1TYWyaPbw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).