public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/78103] Failure to optimize with __builtin_clzl
Date: Mon, 26 Jul 2021 11:14:29 +0000	[thread overview]
Message-ID: <bug-78103-4-Yz1d1YwUJ1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-78103-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78103

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |segher at gcc dot gnu.org

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Unfortunately, it doesn't work for the #c0 testcase, after the combiner
splitter kicks in, the combiner doesn't even try that 4 insn combination. 
Haven't debugged it, but it looks like if LOG_LINKS isn't added between the 2
insns that replaced the 3 insns.
There is the successful:
Trying 9, 10 -> 12:
    9: {flags:CCZ=cmp(r85:DI,0);r86:DI=0x3f-clz(r85:DI);}
      REG_DEAD r85:DI
      REG_UNUSED flags:CCZ
   10: {r86:DI=r86:DI^0x3f;clobber flags:CC;}
      REG_UNUSED flags:CC
   12: r87:DI=sign_extend(r86:DI#0)
      REG_DEAD r86:DI
Failed to match this instruction:
(set (reg:DI 87 [ _1 ])
    (xor:DI (sign_extend:DI (minus:SI (const_int 63 [0x3f])
                (subreg:SI (clz:DI (reg/v:DI 85 [ x ])) 0)))
        (const_int 63 [0x3f])))
Splitting with gen_split_440 (i386.md:14804)
Successfully matched this instruction:
(set (reg:DI 93)
    (minus:DI (const_int 63 [0x3f])
        (clz:DI (reg/v:DI 85 [ x ]))))
Successfully matched this instruction:
(set (reg:DI 87 [ _1 ])
    (zero_extend:DI (xor:SI (subreg:SI (reg:DI 93) 0)
            (const_int 63 [0x3f]))))
allowing combination of insns 9, 10 and 12
original costs 8 + 4 + 4 = 16
replacement costs 8 + 5 = 13
deferring deletion of insn with uid = 9.
modifying insn i2    10: {r93:DI=0x3f-clz(r85:DI);clobber flags:CC;}
      REG_UNUSED flags:CC
      REG_DEAD r85:DI
deferring rescan insn with uid = 10.
modifying insn i3    12: {r87:DI=zero_extend(r93:DI#0^0x3f);clobber flags:CC;}
      REG_UNUSED flags:CC
deferring rescan insn with uid = 12.

and I was hoping that the combiner would soon try 10, 12, 13 -> 14 combination
where 10 and 12 are the above 2 new insns, 13 is r88:DI=0x40
and 14 is {r85:DI=r88:DI-r87:DI;clobber flags:CC;}.
But all it tries is 12 -> 14, 13 -> 14, 13, 12 -> 14 and all those fail.

Segher, any ideas?

  parent reply	other threads:[~2021-07-26 11:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-78103-4@http.gcc.gnu.org/bugzilla/>
2021-07-24  6:20 ` pinskia at gcc dot gnu.org
2021-07-24 12:28 ` jakub at gcc dot gnu.org
2021-07-26 10:57 ` jakub at gcc dot gnu.org
2021-07-26 11:14 ` jakub at gcc dot gnu.org [this message]
2021-07-26 11:22 ` jakub at gcc dot gnu.org
2021-07-26 12:11 ` jakub at gcc dot gnu.org
2021-07-26 21:01 ` segher at gcc dot gnu.org
2021-07-26 21:08 ` jakub at gcc dot gnu.org
2021-07-26 21:26 ` segher at gcc dot gnu.org
2021-07-27  8:52 ` jakub at gcc dot gnu.org
2021-07-27 12:35 ` segher at gcc dot gnu.org
2021-07-27 12:41 ` jakub at gcc dot gnu.org
2021-07-27 13:53 ` jakub at gcc dot gnu.org
2021-07-27 15:25 ` segher at gcc dot gnu.org
2021-07-27 15:37 ` segher at gcc dot gnu.org
2021-07-31  7:21 ` cvs-commit at gcc dot gnu.org
2021-07-31  8:24 ` jakub at gcc dot gnu.org
2021-08-01 20:33 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-78103-4-Yz1d1YwUJ1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).