public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
@ 2021-05-14 9:48 ` jakub at gcc dot gnu.org
2021-06-01 8:08 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-05-14 9:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|8.5 |9.4
--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
2021-05-14 9:48 ` [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239 jakub at gcc dot gnu.org
@ 2021-06-01 8:08 ` rguenth at gcc dot gnu.org
2021-06-12 6:35 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-06-01 8:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.4 |9.5
--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
2021-05-14 9:48 ` [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239 jakub at gcc dot gnu.org
2021-06-01 8:08 ` rguenth at gcc dot gnu.org
@ 2021-06-12 6:35 ` pinskia at gcc dot gnu.org
2021-06-12 6:36 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-06-12 6:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cnsun at uwaterloo dot ca
--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 101036 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-06-12 6:35 ` pinskia at gcc dot gnu.org
@ 2021-06-12 6:36 ` pinskia at gcc dot gnu.org
2021-06-12 6:36 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-06-12 6:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anbu1024.me at gmail dot com
--- Comment #13 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 94730 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-06-12 6:36 ` pinskia at gcc dot gnu.org
@ 2021-06-12 6:36 ` pinskia at gcc dot gnu.org
2021-08-28 20:33 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-06-12 6:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 94731 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2021-06-12 6:36 ` pinskia at gcc dot gnu.org
@ 2021-08-28 20:33 ` pinskia at gcc dot gnu.org
2021-09-01 7:39 ` cvs-commit at gcc dot gnu.org
2021-09-23 3:19 ` pinskia at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-28 20:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
--- Comment #15 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 101365 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2021-08-28 20:33 ` pinskia at gcc dot gnu.org
@ 2021-09-01 7:39 ` cvs-commit at gcc dot gnu.org
2021-09-23 3:19 ` pinskia at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-01 7:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:
https://gcc.gnu.org/g:823685221de986afb729910a6f2237f07a377f17
commit r12-3278-g823685221de986afb729910a6f2237f07a377f17
Author: Roger Sayle <roger@nextmovesoftware.com>
Date: Wed Sep 1 08:38:39 2021 +0100
C: PR c/79412: Poison decls with error_mark_node after type mismatch
This patch fixes an ICE during error-recovery regression in the C
front-end.
The symptom is that the middle-end's sanity checking assertions fail during
gimplification when being asked to increment an array, which is non-sense.
The issue is that the C-front end has detected the type mismatch and
reported an error to the user, but hasn't provided any indication of this
to the middle-end, simply passing bogus trees that the optimizers recognize
as invalid.
This appears to be a frequently reported ICE with 94730, 94731, 101036
and 101365 all marked as duplicates.
I believe the correct (polite) fix is to mark the mismatched types as
problematic/dubious in the front-end, when the error is spotted, so that
the middle-end has a heads-up and can be a little more forgiving. This
patch to c-decl.c's duplicate_decls sets (both) mismatched types to
error_mark_node if they are significantly different, and we've issued
an error message. Alas, this is too punitive for FUNCTION_DECLs where
we store return types, parameter lists, parameter types and attributes
in the type, but fortunately the middle-end is already more cautious
about trusting possibly suspect function types.
This fix required one minor change to the testsuite, typedef-var-2.c
where after conflicting type definitions, we now no longer assume that
the (first or) second definition is the correct one. This change only
affects the behaviour after seen_error(), so should be relatively safe.
2021-09-01 Roger Sayle <roger@nextmovesoftware.com>
Joseph Myers <joseph@codesourcery.com>
gcc/c/ChangeLog
PR c/79412
* c-decl.c (duplicate_decls): On significant mismatches, mark the
types of both (non-function) decls as error_mark_node, so that the
middle-end can see the code is malformed.
(free_attr_access_data): Don't process if the type has been set to
error_mark_node.
gcc/testsuite/ChangeLog
PR c/79412
* gcc.dg/pr79412.c: New test case.
* gcc.dg/typedef-var-2.c: Update expeted errors.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2021-09-01 7:39 ` cvs-commit at gcc dot gnu.org
@ 2021-09-23 3:19 ` pinskia at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-23 3:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79412
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.5 |12.0
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #17 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed on the trunk for GCC 12.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-23 3:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-79412-4@http.gcc.gnu.org/bugzilla/>
2021-05-14 9:48 ` [Bug c/79412] [9/10/11/12 Regression] ICE in fold_convert_loc, at fold-const.c:2239 jakub at gcc dot gnu.org
2021-06-01 8:08 ` rguenth at gcc dot gnu.org
2021-06-12 6:35 ` pinskia at gcc dot gnu.org
2021-06-12 6:36 ` pinskia at gcc dot gnu.org
2021-06-12 6:36 ` pinskia at gcc dot gnu.org
2021-08-28 20:33 ` pinskia at gcc dot gnu.org
2021-09-01 7:39 ` cvs-commit at gcc dot gnu.org
2021-09-23 3:19 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).