[Bug middle-end/79755] [8/9/10 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[Bug middle-end/79755] [8/9/10 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[xerofoify at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Nicholas Krause <xerofoify at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xerofoify at gmail dot com

--- Comment #14 from Nicholas Krause <xerofoify at gmail dot com> ---
Created attachment 48052
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48052&action=edit
Patch for this bug

[Bug middle-end/79755] [8/9/10 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[xerofoify at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

--- Comment #15 from Nicholas Krause <xerofoify at gmail dot com> ---
(In reply to Nicholas Krause from comment #14)
> Created attachment 48052 [details]
> Patch for this bug

After tracking this down to the new function that replaced
verify_edge_corresponds_to_fndecl, cgraph_edge::verify_corresponds_to_fndecl
which is basically the same we run into this:
if (callee->former_clone_of != node->decl
      && (node != callee->ultimate_alias_target ())
      && !clone_of_p (node, callee))


 Basically it appears to be checking we are a former cgraph clone at the same
time as being a current clone or the same node with clone_of_p on the callee
cgraph node. I'm attaching a test patch for this. Gerhard does this fix the
issue?

[Bug middle-end/79755] [8/9/10 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #16 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
That patch will generate a -Wparentheses warning, and more importantly, doesn't
fix the ICE, which you could have tried by yourself.

[Bug middle-end/79755] [8/9/10 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[xerofoify at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

--- Comment #17 from Nicholas Krause <xerofoify at gmail dot com> ---
Sorry about that. I've managed to track it down to a problem with a alias issue 
And from reading the code in the original cvs commit. I'm not able to read it
currently but the original function mentioned seems to now be
cgraph_edge::verify_corresponds_to_fndecl. I've tried to access the original
commit but it complains about permissions. Maybe I'm wrong but this seems very
odd to me:
node = node->ultimate_alias_target ();

is basically referring to itself meaning:
if (callee->former_clone_of != node->decl
      && (node != node->ultimate_alias_target ())
      && !clone_of_p (node, callee))

the && (node != node->ultimate_alias_target ()) is basically referring to
itself when comparing yet its already being defined equal to the return value
of ultimate_alias_target meaning its always true. Not sure if this fixes this
bug or something else. Thoughts?

[Bug middle-end/79755] [9/10/11/12 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

[Bug middle-end/79755] [9/10/11/12 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #19 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug middle-end/79755] [10/11/12/13 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #20 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug middle-end/79755] [10/11/12/13 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #21 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug middle-end/79755] [11/12/13/14 Regression] ICE: segfault in cgraph_node::get, at cgraph.h:1261

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79755

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #22 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.