public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "meissner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/81594] Optimize PowerPC vector set and store Date: Wed, 25 Mar 2020 15:38:18 +0000 [thread overview] Message-ID: <bug-81594-4-wyZiuJNl8M@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-81594-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81594 --- Comment #6 from Michael Meissner <meissner at gcc dot gnu.org> --- If you look at the original patch, it did try to do this optimization. When I looked at it some time later, the combiner no longer generated the sequence because it thought it was slower (due to length, etc.). You could spend a lot of time tuning the code so eventually the combiner will generate it again, but it was simpler to just put the peephole in to catch the cases that show up. If you want to take on the bug and do it earlier, go ahead. A peephole2 might not catch all uses, but it prevents whack-a-mole, where a change causes other code generation changes down the pike. Note, the original patch was written in the power8 time frame, and it would need to be adjust to power9 and future systems now (i.e. the patch only does the splitting if the value is a FPR or GPR, while in power9 it could be a traditional Altivec register). However, the splitter uses reload_completed that you always seem to object to. It could be done before register allocation, but then you would need to make sure that no other pass recombines the two separate items back into a vector once again.
next prev parent reply other threads:[~2020-03-25 15:38 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-81594-4@http.gcc.gnu.org/bugzilla/> 2020-03-18 16:44 ` meissner at gcc dot gnu.org 2020-03-25 8:59 ` segher at gcc dot gnu.org 2020-03-25 15:38 ` meissner at gcc dot gnu.org [this message] 2020-03-25 18:40 ` segher at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-81594-4-wyZiuJNl8M@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).