* [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented
[not found] <bug-81689-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-23 8:46 ` burnus at gcc dot gnu.org
2020-03-23 14:21 ` burnus at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2020-03-23 8:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81689
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |burnus at gcc dot gnu.org
Depends on| |94251
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
I believe the compile-time issue has been fixed by PR 94233.
There is a run-time issue which is tracked by PR 94251.
NOTE: This test is currently disabled
(since r10-6542-gfd789c816b06235b04698636db69e302b24c83ba ) due to the fails.
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94251
[Bug 94251] [OpenMP] 'target link' fails at run time /
libgomp.c/target-link-1.c fails on GCN
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented
[not found] <bug-81689-4@http.gcc.gnu.org/bugzilla/>
2020-03-23 8:46 ` [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented burnus at gcc dot gnu.org
@ 2020-03-23 14:21 ` burnus at gcc dot gnu.org
2020-03-24 14:14 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2020-03-23 14:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81689
--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
While the two PRs have fixed offloading for AMDGCN, nvptx still fails with the
same error. The generated assembler is:
"ld.global.u64 %r27,[a$linkptr];\n"
But there is NO associated global-var declaration
similar to:
"// BEGIN GLOBAL VAR DECL: __nvptx_uni\n"
".extern .shared .u32 __nvptx_uni[32];\n"
In principle, it should be generated by nvptx_output_aligned_decl – but this
never called. It is currently called via ASM_OUTPUT_ALIGNED_DECL_COMMON and
ASM_OUTPUT_ALIGNED_DECL_LOCAL.
Without proper debugging, I have the feeling that ASM_OUTPUT_ALIGNED_BSS is
called for this – but that's not defined for nvptx. Nor is
TARGET_ASM_SELECT_SECTION.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented
[not found] <bug-81689-4@http.gcc.gnu.org/bugzilla/>
2020-03-23 8:46 ` [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented burnus at gcc dot gnu.org
2020-03-23 14:21 ` burnus at gcc dot gnu.org
@ 2020-03-24 14:14 ` cvs-commit at gcc dot gnu.org
2020-03-24 16:22 ` burnus at gcc dot gnu.org
2020-03-24 16:23 ` burnus at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-03-24 14:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81689
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:
https://gcc.gnu.org/g:c2211a60ff05b7a0289d3e287e72c181bb4d5d8b
commit r10-7354-gc2211a60ff05b7a0289d3e287e72c181bb4d5d8b
Author: Tobias Burnus <tobias@codesourcery.com>
Date: Tue Mar 24 15:13:56 2020 +0100
Fix OpenMP offload handling for target-link variables for nvptx (PR81689)
PR libgomp/81689
* lto.c (offload_handle_link_vars): Propagate TREE_PUBLIC state.
PR libgomp/81689
* omp-offload.c (omp_finish_file): Fix target-link handling if
targetm_common.have_named_sections is false.
PR libgomp/81689
* testsuite/libgomp.c/target-link-1.c: Remove xfail.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented
[not found] <bug-81689-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-03-24 14:14 ` cvs-commit at gcc dot gnu.org
@ 2020-03-24 16:22 ` burnus at gcc dot gnu.org
2020-03-24 16:23 ` burnus at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2020-03-24 16:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81689
Bug 81689 depends on bug 94251, which changed state.
Bug 94251 Summary: [OpenMP] 'target link' fails at run time / libgomp.c/target-link-1.c fails on GCN
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94251
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug libgomp/81689] libgomp.c/target-link-1.c fails for nvptx: #pragma omp target link not implemented
[not found] <bug-81689-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-03-24 16:22 ` burnus at gcc dot gnu.org
@ 2020-03-24 16:23 ` burnus at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2020-03-24 16:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81689
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED.
^ permalink raw reply [flat|nested] 5+ messages in thread