public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/82090] Bogus warning: ‘magic_p’ may be used uninitialized in this function [-Wmaybe-uninitialized] Date: Wed, 01 Dec 2021 15:50:35 +0000 [thread overview] Message-ID: <bug-82090-4-ypV3ERsJJj@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-82090-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82090 --- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> --- [from the POC patch] It seems that every missed thread (due to inability of the threader, or due to cost restraints) is a potential false positive for the uninit code. Perhaps what we need is a way to identify threading opportunities without doing the actual threading. The attached is a proof-of-concept that does just that. Basically a lof of these PRs look like: x_5 = PHI <UNDEF(10), x_8(20), x_10(30)> ... ... if (cond_8) use(x_5); This looks like a path from the definition of x_5 to the cond_8 check. If the incoming path through BB10 can be determined to elide the use of x_5, we could disregard this as a false positive. This patch solves PR82090, but it would need to be properly incorporated into the uninit pass. For instance, I'm finding paths from USE back to DEF, but the uninit pass is in a much better position to tell us what the starting point of the path is. It's likely to be further up the chain through a maze of feeding PHIs. This is just meant as a stop gap to help in reducing the false positive rate, nothing fancy. Maybe the work by Martin Liska and Richi on loop unswitching would be a better solution. Anywhoo... Maybe someone with knowledge of the uninit pass could explore this. Just a thought.
next prev parent reply other threads:[~2021-12-01 15:50 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-82090-4@http.gcc.gnu.org/bugzilla/> 2021-04-13 21:15 ` msebor at gcc dot gnu.org 2021-11-30 16:59 ` aldyh at gcc dot gnu.org 2021-12-01 15:50 ` aldyh at gcc dot gnu.org 2021-12-01 15:50 ` aldyh at gcc dot gnu.org [this message] 2021-12-01 16:02 ` law at gcc dot gnu.org 2021-12-02 18:22 ` aldyh at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-82090-4-ypV3ERsJJj@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).