From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 9A9803858C60; Fri,  2 Dec 2022 09:34:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A9803858C60
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1669973675;
	bh=Hyzbzi4gui/RsdDFxl6XNdpprJar423YLla6x7fhBZ0=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=KBmv3RwZZYeej9Rbij86nS78k6Fghjo5DQ6+qeQ5L/+tOpntE13oxSQhRGsOdrHLG
	 oezsBgM9vUMJMbu9TgWWl3pSAPxkJ2+CiNm5P1nMpAseF3Ui91Hx6jUHEakF2mWWuC
	 xqEUVR2tT+EMjqHErD6Lgx2geqXv0u6MxzJyA7mA=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/84469] structured binding inside for all loop thinks it is
 type depedent when it is not (inside a template)
Date: Fri, 02 Dec 2022 09:34:34 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 8.0.1
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-84469-4-AnbT1dqk55@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-84469-4@http.gcc.gnu.org/bugzilla/>
References: <bug-84469-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D84469

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ee4f25999f6832a1c5060b9277222c03d852709a

commit r13-4460-gee4f25999f6832a1c5060b9277222c03d852709a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Dec 2 10:29:11 2022 +0100

    c++: Deduce range for structured bindings if expression is not type
dependent [PR84469]

    As shown on the decomp56.C testcase, if the range for expression
    when using structured bindings is not type dependent, we deduce
    the finish the structured binding types only when not in template
    (cp_convert_range_for takes care of that), but if in templates,
    do_range_for_auto_deduction is called instead and it doesn't handle
    structured bindings.  During instantiation they are handled later,
    but during the parsing keeping the structured bindings type
    dependent when they shouldn't be changes behavior.
    The following patch calls cp_finish_decomp even from
    do_range_for_auto_deduction.
    The patch regresses the OpenMP g++.dg/gomp/for-21.C test (3 errors
    are gone), I'll post an incremental patch for it momentarily.

    2022-12-02  Jakub Jelinek  <jakub@redhat.com>

            PR c++/84469
            * parser.cc (do_range_for_auto_deduction): Add DECOMP_FIRST_NAME
            and DECOMP_CNT arguments.  Call cp_finish_decomp if DECL
            is a structured binding.
            (cp_parser_range_for): Adjust do_range_for_auto_deduction calle=
r.
            (cp_convert_omp_range_for): Likewise.

            * g++.dg/cpp1z/decomp56.C: New test.
            * g++.dg/gomp/pr84469.C: New test.=