* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
@ 2023-07-25 16:16 ` pinskia at gcc dot gnu.org
2023-07-25 16:16 ` pinskia at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-25 16:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |redi at gcc dot gnu.org
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110802 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
2023-07-25 16:16 ` [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template pinskia at gcc dot gnu.org
@ 2023-07-25 16:16 ` pinskia at gcc dot gnu.org
2023-07-25 21:12 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-25 16:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-07-25
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
2023-07-25 16:16 ` [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template pinskia at gcc dot gnu.org
2023-07-25 16:16 ` pinskia at gcc dot gnu.org
@ 2023-07-25 21:12 ` redi at gcc dot gnu.org
2023-07-26 16:02 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2023-07-25 21:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This affects std::random_shuffle in libstdc++, which only warns with clang, not
gcc. The attribute needs to be on the first declaration to work with gcc.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2023-07-25 21:12 ` redi at gcc dot gnu.org
@ 2023-07-26 16:02 ` cvs-commit at gcc dot gnu.org
2023-07-28 17:32 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-07-26 16:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:c01b344e814001e07fd304ce98d013d811e90192
commit r14-2796-gc01b344e814001e07fd304ce98d013d811e90192
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Jul 26 14:05:58 2023 +0100
libstdc++: Add deprecated attribute to std::random_shuffle declarations
We already have these attributes on the definitions in <bits/stl_algo.h>
but they don't work due to PR c++/84542. Add the attributes to the
declarations in <bits/algorithmfwd.h> as well, and add a test.
libstdc++-v3/ChangeLog:
* include/bits/algorithmfwd.h (random_shuffle): Add deprecated
attribute.
* include/bits/stl_algo.h (random_shuffle): Correct comments.
* testsuite/25_algorithms/random_shuffle/1.cc: Disable
deprecated warnings.
* testsuite/25_algorithms/random_shuffle/59603.cc: Likewise.
* testsuite/25_algorithms/random_shuffle/moveable.cc: Likewise.
* testsuite/25_algorithms/random_shuffle/deprecated.cc: New
test.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2023-07-26 16:02 ` cvs-commit at gcc dot gnu.org
@ 2023-07-28 17:32 ` cvs-commit at gcc dot gnu.org
2023-12-21 19:34 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-07-28 17:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:3f78294969641cb762dc2abcd832c7d3edeefa79
commit r13-7624-g3f78294969641cb762dc2abcd832c7d3edeefa79
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Jul 26 14:05:58 2023 +0100
libstdc++: Add deprecated attribute to std::random_shuffle declarations
We already have these attributes on the definitions in <bits/stl_algo.h>
but they don't work due to PR c++/84542. Add the attributes to the
declarations in <bits/algorithmfwd.h> as well, and add a test.
libstdc++-v3/ChangeLog:
* include/bits/algorithmfwd.h (random_shuffle): Add deprecated
attribute.
* include/bits/stl_algo.h (random_shuffle): Correct comments.
* testsuite/25_algorithms/random_shuffle/1.cc: Disable
deprecated warnings.
* testsuite/25_algorithms/random_shuffle/59603.cc: Likewise.
* testsuite/25_algorithms/random_shuffle/moveable.cc: Likewise.
* testsuite/25_algorithms/random_shuffle/deprecated.cc: New
test.
(cherry picked from commit c01b344e814001e07fd304ce98d013d811e90192)
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2023-07-28 17:32 ` cvs-commit at gcc dot gnu.org
@ 2023-12-21 19:34 ` cvs-commit at gcc dot gnu.org
2023-12-21 19:35 ` ppalka at gcc dot gnu.org
2024-03-18 14:05 ` cvs-commit at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-12-21 19:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:9a65c8ee659042babdb05ef15fea9910fa8d6e62
commit r14-6790-g9a65c8ee659042babdb05ef15fea9910fa8d6e62
Author: Patrick Palka <ppalka@redhat.com>
Date: Thu Dec 21 14:33:56 2023 -0500
c++: [[deprecated]] on template redecl [PR84542]
The deprecated and unavailable attributes weren't working when used on
a template redeclaration ultimately because we weren't merging the
corresponding tree flags in duplicate_decls.
PR c++/84542
gcc/cp/ChangeLog:
* decl.cc (merge_attribute_bits): Merge TREE_DEPRECATED
and TREE_UNAVAILABLE.
gcc/testsuite/ChangeLog:
* g++.dg/ext/attr-deprecated-2.C: No longer XFAIL.
* g++.dg/ext/attr-unavailable-12.C: New test.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2023-12-21 19:34 ` cvs-commit at gcc dot gnu.org
@ 2023-12-21 19:35 ` ppalka at gcc dot gnu.org
2024-03-18 14:05 ` cvs-commit at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: ppalka at gcc dot gnu.org @ 2023-12-21 19:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ppalka at gcc dot gnu.org
Status|NEW |RESOLVED
Target Milestone|--- |14.0
Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot gnu.org
Resolution|--- |FIXED
--- Comment #8 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 14.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug c++/84542] missing -Wdeprecated-declarations on a redeclared function template
[not found] <bug-84542-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2023-12-21 19:35 ` ppalka at gcc dot gnu.org
@ 2024-03-18 14:05 ` cvs-commit at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-18 14:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84542
--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:bfa7e7dfc19e07bff319636cf1bdfd57b6c68f41
commit r12-10245-gbfa7e7dfc19e07bff319636cf1bdfd57b6c68f41
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Jul 26 14:05:58 2023 +0100
libstdc++: Add deprecated attribute to std::random_shuffle declarations
We already have these attributes on the definitions in <bits/stl_algo.h>
but they don't work due to PR c++/84542. Add the attributes to the
declarations in <bits/algorithmfwd.h> as well, and add a test.
libstdc++-v3/ChangeLog:
* include/bits/algorithmfwd.h (random_shuffle): Add deprecated
attribute.
* include/bits/stl_algo.h (random_shuffle): Correct comments.
* testsuite/25_algorithms/random_shuffle/1.cc: Disable
deprecated warnings.
* testsuite/25_algorithms/random_shuffle/59603.cc: Likewise.
* testsuite/25_algorithms/random_shuffle/moveable.cc: Likewise.
* testsuite/25_algorithms/random_shuffle/deprecated.cc: New
test.
(cherry picked from commit c01b344e814001e07fd304ce98d013d811e90192)
^ permalink raw reply [flat|nested] 8+ messages in thread