public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/84695] Missed opportunity to issue warning about override
Date: Fri, 07 Jan 2022 03:56:55 +0000	[thread overview]
Message-ID: <bug-84695-4-44JDxNTZjo@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-84695-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84695

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Clang has -Winconsistent-missing-override which is turned on by default and
provides the warning:

<source>:8:7: warning: 'two' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
  int two(int) { return 102; }
      ^
<source>:4:15: note: overridden virtual function is here
  virtual int two(int) { return 2; }
              ^

  reply	other threads:[~2022-01-07  3:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-04  6:16 [Bug c++/84695] New: " drepper.fsp+rhbz at gmail dot com
2022-01-07  3:56 ` pinskia at gcc dot gnu.org [this message]
2022-02-04  8:03 ` [Bug c++/84695] Missed opportunity to issue warning about override [-Winconsistent-missing-override] egallager at gcc dot gnu.org
2022-07-15  6:38 ` dcb314 at hotmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-84695-4-44JDxNTZjo@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).