From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id E971C3858C31; Tue, 13 Jun 2023 21:43:55 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E971C3858C31
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1686692635;
	bh=gI1+7T7+AybzI3cDmBZoIqT4YMxAJkdNiVcpRomqEGk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=eKfAOctvTTKMJ69A5OTc+i5BcKhhCOsND6v+uD7QOrOOLaDqy4KPh74/0lzGmwthZ
	 GvCkHH2WCRg9dYg0+q6UNyrlDHAeTA+kCquTeAg6nvxM1TGM4wgyzZM8fymBwAza7R
	 jmrmdSDG4cGBLVgLdNuBI4pMc374HZqZEg4qI8ZM=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/84890] Overly verbose notes for missing headers
Date: Tue, 13 Jun 2023 21:43:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 8.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-84890-4-TVpoLo1ew6@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-84890-4@http.gcc.gnu.org/bugzilla/>
References: <bug-84890-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D84890

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:7474c46cf2d3715fe23871671c756fd5f65bc225

commit r14-1798-g7474c46cf2d3715fe23871671c756fd5f65bc225
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Tue Jun 13 17:42:47 2023 -0400

    c/c++: use positive tone in missing header notes [PR84890]

    Quoting "How a computer should talk to people" (as quoted
    in "Concepts Error Messages for Humans"):

    "Various negative tones or actions are unfriendly: being manipulative,
    not giving a second chance, talking down, using fashionable slang,
    blaming. We must not seem to blame the person. We should avoid suggesti=
ng
    that the person is inadequate. Phrases like "you forgot" may seem
    harmless, but what if a computer said this to you four or five times in
    two minutes? Anyway, the person may disagree, so why risk offense?"

    gcc/c-family/ChangeLog:
            PR c/84890
            * known-headers.cc
            (suggest_missing_header::~suggest_missing_header): Reword note =
to
            avoid negative tone of "forgetting".

    gcc/cp/ChangeLog:
            PR c/84890
            * name-lookup.cc (missing_std_header::~missing_std_header): Rew=
ord
            note to avoid negative tone of "forgetting".

    gcc/testsuite/ChangeLog:
            PR c/84890
            * g++.dg/cpp2a/srcloc3.C: Update expected message.
            * g++.dg/lookup/missing-std-include-2.C: Likewise.
            * g++.dg/lookup/missing-std-include-3.C: Likewise.
            * g++.dg/lookup/missing-std-include-6.C: Likewise.
            * g++.dg/lookup/missing-std-include.C: Likewise.
            * g++.dg/spellcheck-inttypes.C: Likewise.
            * g++.dg/spellcheck-stdint.C: Likewise.
            * g++.dg/spellcheck-stdlib.C: Likewise.
            * gcc.dg/spellcheck-inttypes.c: Likewise.
            * gcc.dg/spellcheck-stdbool.c: Likewise.
            * gcc.dg/spellcheck-stdint.c: Likewise.
            * gcc.dg/spellcheck-stdlib.c: Likewise.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>=