From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id CF006385842C; Fri, 25 Feb 2022 13:01:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF006385842C
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/85487] Support '#pragma region' and '#pragma endregion' to
 allow code folding with Visual Studio
Date: Fri, 25 Feb 2022 13:01:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 8.0.1
X-Bugzilla-Keywords: easyhack
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: rsandifo at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-85487-4-0BE4LvQvlT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-85487-4@http.gcc.gnu.org/bugzilla/>
References: <bug-85487-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Feb 2022 13:01:52 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D85487

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rsandifo at gcc dot gnu.org

--- Comment #12 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.o=
rg> ---
(In reply to Jonathan Wakely from comment #9)
> (In reply to Jakub Jelinek from comment #7)
> > I would say that is a terrible design...
>=20
> Yes, I completely agree, but I don't see why GCC should be in the business
> of diagnosing other people's junk :-)
>=20
> Maybe Visual Studio's editor and VScode do have checks, just not the VC++
> compiler. And if so, then that's even more reason that we don't need GCC =
to
> do its own checking.
Agreed.  And if people with strict linting requirements want
a warning about pragmas that are recognised but have no effect
on the compiler, we could still provide an option to do that
(but it shouldn't be in -Wall or even -Wextra).

That shouldn't be a requirement for this PR though, unless anyone
can show that someone somewhere really does want these pragmas to
generate a warning.

Jeff said at the end of the thread that he wouldn't mind
if someone else approves it, so it's probably worth posting
again.  The patch LGTM FWIW: only (very) minor comment is that
the unused argument name in handle_pragma_region can be dropped.

I think the patch would need to wait for GCC 13 now though.=