From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 591BE3858C83; Tue, 15 Feb 2022 15:32:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 591BE3858C83 From: "redi at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/85487] Support '#pragma region' and '#pragma endregion' to allow code folding with Visual Studio Date: Tue, 15 Feb 2022 15:32:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Version: 8.0.1 X-Bugzilla-Keywords: easyhack X-Bugzilla-Severity: enhancement X-Bugzilla-Who: redi at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2022 15:32:22 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D85487 --- Comment #8 from Jonathan Wakely --- (In reply to Austin Morton from comment #5) > https://gcc.gnu.org/pipermail/gcc-patches/2020-September/553182.html >=20 > I sent a patch to do exactly that in 2020 and it was not accepted. Thanks. The review thread continues in November (but the mail archive doesn= 't thread it properly across months): https://gcc.gnu.org/pipermail/gcc-patches/2020-November/558900.html I see what Jeff is saying, but I think the pragmatic approach here is to ju= st do exactly what your patch does: hardcode this warning as a no-op. We don't have to do that for every pragma implemented by every compiler, because giv= ing a -Wunknown-pragmas warning about *unknown* pragmas is useful. GCC doesn't = know what the pragma was attempting to do, so it should warn. But we do know what this one does: nothing. It's not unknown.=