From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id EB6543858C1F; Fri, 25 Feb 2022 14:46:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB6543858C1F
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/85487] Support '#pragma region' and '#pragma endregion' to
 allow code folding with Visual Studio
Date: Fri, 25 Feb 2022 14:46:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 8.0.1
X-Bugzilla-Keywords: easyhack
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-85487-4-TSC0CynLvr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-85487-4@http.gcc.gnu.org/bugzilla/>
References: <bug-85487-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Feb 2022 14:46:53 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D85487

--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to rsandifo@gcc.gnu.org from comment #12)
> Jeff said at the end of the thread that he wouldn't mind
> if someone else approves it, so it's probably worth posting
> again.

OK, will do.

I think Jeff's desire for a framework to ignore arbitrary pragmas might be
nice, but nobody's going to do that, and this small improvement has a worki=
ng
patch. We shouldn't let the perfect be the enemy of the good.

> The patch LGTM FWIW: only (very) minor comment is that
> the unused argument name in handle_pragma_region can be dropped.

Yeah, that was consistent with the rest of the file, but I already changed =
the
rest in r12-7282-g73a118c209fcbb so I'd update my patch in the same way.

I'll also update it to ignore the very similar Xcode pragmas described in PR
61593.

> I think the patch would need to wait for GCC 13 now though.

Indeed.=