public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "slyfox at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/85621] savms/resms have executable stack (lack GNU-stack marking)
Date: Sat, 06 Feb 2021 11:59:41 +0000	[thread overview]
Message-ID: <bug-85621-4-tbOKc68IiJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-85621-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85621

Sergei Trofimovich <slyfox at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at redhat dot com
             Status|NEW                         |ASSIGNED
                 CC|                            |slyfox at gcc dot gnu.org

--- Comment #5 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
I think it was fixed with

commit 686b1cdfdc46a476056fe4df6e8186be8c889aca
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 27 11:49:23 2021 +0100

    libgcc, i386: Add .note.GNU-stack sections to the ms sse/avx sav/res

    On Linux, GCC emits .note.GNU-stack sections when compiling code to mark
    the code as not needing or needing executable stack, missing section means
    unknown.  But assembly files need to be marked manually.  We already
    mark various *.S files in libgcc manually, but the
    avx_resms64f.o
    avx_resms64fx.o
    avx_resms64.o
    avx_resms64x.o
    avx_savms64f.o
    avx_savms64.o
    sse_resms64f.o
    sse_resms64fx.o
    sse_resms64.o
    sse_resms64x.o
    sse_savms64f.o
    sse_savms64.o
    files aren't marked, so when something links it in, it will require
    executable stack.  Nothing in the assembly requires executable stack
though.

    2021-01-27  Jakub Jelinek  <jakub@redhat.com>

            * config/i386/savms64.h: Add .note.GNU-stack section on Linux.
            * config/i386/savms64f.h: Likewise.
            * config/i386/resms64.h: Likewise.
            * config/i386/resms64f.h: Likewise.
            * config/i386/resms64x.h: Likewise.
            * config/i386/resms64fx.h: Likewise.

       reply	other threads:[~2021-02-06 11:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-85621-4@http.gcc.gnu.org/bugzilla/>
2021-02-06 11:59 ` slyfox at gcc dot gnu.org [this message]
2021-02-06 12:01 ` slyfox at inbox dot ru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-85621-4-tbOKc68IiJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).