public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/86355] [9/10 Regression] Internal compiler error with pack expansion and fold expression
Date: Fri, 13 May 2022 17:13:50 +0000	[thread overview]
Message-ID: <bug-86355-4-Rnl8STxkaW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-86355-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86355

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:aa030fca4b7257656aa6bfe879d79a332b3c39ea

commit r10-10733-gaa030fca4b7257656aa6bfe879d79a332b3c39ea
Author: Jason Merrill <jason@redhat.com>
Date:   Wed May 26 17:38:42 2021 -0400

    c++: argument pack with expansion [PR86355]

    This testcase revealed that we were using PACK_EXPANSION_EXTRA_ARGS a lot
    more than necessary; use_pack_expansion_extra_args_p meant to use it in the
    case of corresponding arguments in different argument packs differing in
    whether they are pack expansions, but it was mistakenly also returning true
    for the case of a single argument pack containing both expansion and
    non-expansion elements.

    Surprisingly, just disabling that didn't lead to any regressions in the
    testsuite; it seems other changes have prevented us getting to this point
    for code that used to exercise it.  So this patch limits the check to
    arguments in the same position in the packs, and asserts that we never
    actually see a mismatch.

            PR c++/86355

    gcc/cp/ChangeLog:

            * pt.c (use_pack_expansion_extra_args_p): Don't compare
            args from the same argument pack.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/alias-decl-variadic2.C: New test.

  parent reply	other threads:[~2022-05-13 17:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-86355-4@http.gcc.gnu.org/bugzilla/>
2021-05-03 19:01 ` [Bug c++/86355] [8/9/10/11/12 " ppalka at gcc dot gnu.org
2021-05-14  9:50 ` [Bug c++/86355] [9/10/11/12 " jakub at gcc dot gnu.org
2021-05-26 21:37 ` jason at gcc dot gnu.org
2021-05-27 17:42 ` cvs-commit at gcc dot gnu.org
2021-06-01  8:11 ` rguenth at gcc dot gnu.org
2021-07-09 20:14 ` [Bug c++/86355] [9/10/11 " cvs-commit at gcc dot gnu.org
2022-05-13 17:13 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-27  9:39 ` [Bug c++/86355] [10 " rguenth at gcc dot gnu.org
2022-06-28 10:35 ` jakub at gcc dot gnu.org
2023-07-07  8:02 ` rguenth at gcc dot gnu.org
2023-07-07  8:13 ` pdimov at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-86355-4-Rnl8STxkaW@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).