[Bug c++/86385] calling wrong constructors?

[Bug c++/86385] calling wrong constructors?

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86385

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2018-07-03 00:00:00         |2021-5-13

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
It's not calling the wrong constructor, GCC is just making a trivial copy of
the object (without using any constructor) for the second operand of the ?:
expression. That is never constructed using a constructor, but it is destroyed,
which causes the double free.

;; Function main (main, funcdef_no=14, decl_uid=2419, cgraph_uid=15,
symbol_order=14) (executed once)

int main ()
{
  struct A D.2421;
  struct A D.2423;
  void * _8;

  <bb 2> [local count: 1073741824]:
  D.2421 ={v} {CLOBBER};
  _8 = operator new (4);
  MEM[(int *)_8] = 42;
  D.2421.a = _8;
  __builtin_printf ("C %p\n", &D.2421);
  D.2423 = D.2421;
  A::~A (&D.2423);
  D.2423 ={v} {CLOBBER};
  A::~A (&D.2421);
  D.2421 ={v} {CLOBBER};
  return 0;

}

[Bug c++/86385] calling wrong constructors?

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86385

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |st at quanttec dot com

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 92467 has been marked as a duplicate of this bug. ***

[Bug c++/86385] calling wrong constructors?

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86385

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |13.0
             Status|NEW                         |RESOLVED

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed for GCC 13+ by r13-2964-gbbdb5612f6661f2c64b0c0f1d2291cb59fde2b40 .

[Bug c++/86385] calling wrong constructors?

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86385

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #5)
> Fixed for GCC 13+ by r13-2964-gbbdb5612f6661f2c64b0c0f1d2291cb59fde2b40 .

Or by r13-2963-g32b2eb59fb9049 .

Anyways both together are needed IIRC.