public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/86385] calling wrong constructors?
Date: Thu, 13 May 2021 13:03:04 +0000	[thread overview]
Message-ID: <bug-86385-4-ykjrQlnwN8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-86385-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86385

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2018-07-03 00:00:00         |2021-5-13

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
It's not calling the wrong constructor, GCC is just making a trivial copy of
the object (without using any constructor) for the second operand of the ?:
expression. That is never constructed using a constructor, but it is destroyed,
which causes the double free.

;; Function main (main, funcdef_no=14, decl_uid=2419, cgraph_uid=15,
symbol_order=14) (executed once)

int main ()
{
  struct A D.2421;
  struct A D.2423;
  void * _8;

  <bb 2> [local count: 1073741824]:
  D.2421 ={v} {CLOBBER};
  _8 = operator new (4);
  MEM[(int *)_8] = 42;
  D.2421.a = _8;
  __builtin_printf ("C %p\n", &D.2421);
  D.2423 = D.2421;
  A::~A (&D.2423);
  D.2423 ={v} {CLOBBER};
  A::~A (&D.2421);
  D.2421 ={v} {CLOBBER};
  return 0;

}

       reply	other threads:[~2021-05-13 13:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-86385-4@http.gcc.gnu.org/bugzilla/>
2021-05-13 13:03 ` redi at gcc dot gnu.org [this message]
2021-08-10  0:39 ` pinskia at gcc dot gnu.org
2024-03-14 18:21 ` pinskia at gcc dot gnu.org
2024-03-14 18:22 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-86385-4-ykjrQlnwN8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).