[Bug ada/864] --program-suffix is ignored (for ada)

[Bug ada/864] --program-suffix is ignored (for ada)

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

Dave Korn <davek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #20 from Dave Korn <davek at gcc dot gnu.org> 2011-12-07 00:42:31 UTC ---
And re-reopened.  In the patch applied at comment 10, this code from
Program_Name ...

      if End_Of_Prefix > 1 then
         Start_Of_Suffix := End_Of_Prefix + Prog'Length + 1;
      end if;

... means that it only recognizes a suffix if there is also a prefix, i.e. it
only works for cross-compilers.  The documentation suggests this is deliberate:

   function Program_Name (Nam : String; Prog : String) return String_Access;
   --  In the native compilation case, Create a string containing Nam. In the
   --  cross compilation case, looks at the prefix of the current program being
   --  run and prepend it to Nam. For instance if the program being run is
   --  <target>-gnatmake and Nam is "gcc", the returned value will be a pointer
   --  to "<target>-gcc". In the specific case where AAMP_On_Target is set, the
   --  name "gcc" is mapped to "gnaamp", and names of the form "gnat*" are
   --  mapped to "gnaamp*". This function clobbers Name_Buffer and Name_Len.
   --  Also look at any suffix, e.g. gnatmake-4.1 -> "gcc-4.1". Prog is the
   --  default name of the current program being executed, e.g. "gnatmake",
   --  "gnatlink".

... but why?  The native behaviour is wrong and it seems incorrect to me that
it should have different semantics from the cross-compiler case.

I would also very much like to see the patch in comment 16 applied.  There is
now a second report open at bug 51095, I will mark it as a dup.  Are there
copyright or licensing reasons why it would have to be submitted by RG, or does
posting it in BZ count as an assignment?

[Bug ada/864] --program-suffix is ignored (for ada)

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

Dave Korn <davek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at grondar dot org

--- Comment #21 from Dave Korn <davek at gcc dot gnu.org> 2011-12-07 00:45:10 UTC ---
*** Bug 51095 has been marked as a duplicate of this bug. ***

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

--- Comment #22 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-12-07 12:54:15 UTC ---
(In reply to comment #20)
> I would also very much like to see the patch in comment 16 applied.  There is
> now a second report open at bug 51095, I will mark it as a dup.  Are there
> copyright or licensing reasons why it would have to be submitted by RG, or does
> posting it in BZ count as an assignment?

Technically I took the patch from Debian, so it's their duty to submit it.

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18256|0                           |1
        is obsolete|                            |
             Status|REOPENED                    |ASSIGNED
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #23 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-04 13:53:21 UTC ---
Created attachment 29083
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29083
updated patch

Updated patch, for 4.8.

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

--- Comment #24 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 10:14:54 UTC ---
Author: rguenth
Date: Mon Jan  7 10:14:48 2013
New Revision: 194964

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194964
Log:
2013-01-04  Richard Biener  <rguenther@suse.de>

    PR ada/864
    * gcc-interface/Make-lang.in (ada.install-common): Always apply
    program_transform_name.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/Make-lang.in

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.8.0

--- Comment #25 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 10:17:09 UTC ---
Fixed for 4.8.

[Bug ada/864] --program-suffix is ignored (for ada)

[davek at gcc dot gnu dot org]

------- Comment #19 from davek at gcc dot gnu dot org  2009-07-26 20:57 -------
(In reply to comment #18)

> No, the support that was implemented is that the suffix of gnatmake
> is the one that gcc gets suffixed with.

Ah ok, I see.  Then it's working as designed.  Sorry for the noise in your
inbox.    Judging from the way your patch only changes the names at install
time, I expect that if I manually rename the files after they've been
installed, they'll also notice their new suffixes and it should all work ok. 
Bug reclosed.


-- 

davek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenther at suse dot de]

------- Comment #18 from rguenther at suse dot de  2009-07-26 20:44 -------
Subject: Re:  --program-suffix is ignored (for ada)

On Sun, 26 Jul 2009, davek at gcc dot gnu dot org wrote:

> ------- Comment #17 from davek at gcc dot gnu dot org  2009-07-26 20:39 -------
> (In reply to comment #15)
> > Right, my change fixed gnatmake so that it would call the proper gcc (based on
> > the
> > previous comments on this PR), but Makefiles have never supported 
> > --program-suffix, so that's not even a regression.
> 
>   Uh, you both focussed on the line where I mentioned in passing that the gnat
> executables don't get suffixed, and missed the actual bug report: it does *not*
> call the proper GCC.  Regardless of whether gnatmake itself gets a suffix or
> not, it should have invoked "gcc-4", not "gcc", shouldn't it?

No, the support that was implemented is that the suffix of gnatmake
is the one that gcc gets suffixed with.

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[davek at gcc dot gnu dot org]

------- Comment #17 from davek at gcc dot gnu dot org  2009-07-26 20:39 -------
(In reply to comment #15)
> Right, my change fixed gnatmake so that it would call the proper gcc (based on
> the
> previous comments on this PR), but Makefiles have never supported 
> --program-suffix, so that's not even a regression.

  Uh, you both focussed on the line where I mentioned in passing that the gnat
executables don't get suffixed, and missed the actual bug report: it does *not*
call the proper GCC.  Regardless of whether gnatmake itself gets a suffix or
not, it should have invoked "gcc-4", not "gcc", shouldn't it?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2009-07-26 20:37 -------
Created an attachment (id=18256)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18256&action=view)
patch

FYI this is what SUSE carries along.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #15 from charlet at gcc dot gnu dot org  2009-07-26 20:33 -------
Right, my change fixed gnatmake so that it would call the proper gcc (based on
the
previous comments on this PR), but Makefiles have never supported 
--program-suffix, so that's not even a regression.

Feel free to submit a patch, I think it would be fair for someone with an
interest in this feature to do so, since Ada maintainers have no specific
interest in this option, and this is really a Makefile/infrastructure issue
at this stage rather than an Ada issue (I did fix the Ada specific issue
reported
in gnatmake, and this feature is still working AFAIK).


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|charlet at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|REOPENED                    |NEW
   Target Milestone|4.4.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[rguenth at gcc dot gnu dot org]

------- Comment #14 from rguenth at gcc dot gnu dot org  2009-07-26 19:53 -------
>  None of the newly built gnat* executables had the --program-suffix appended.

that never happened.  Distros carry patches for this since ages.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[davek at gcc dot gnu dot org]

------- Comment #13 from davek at gcc dot gnu dot org  2009-07-26 14:26 -------
  Broken again on HEAD :-(

  Configured with --program-suffix=-4, bootstrapped, and installed into a new
$prefix that I then placed at the front of $PATH.

  None of the newly built gnat* executables had the --program-suffix appended.

  When trying to run the testsuite, host_gnatmake invokes plain unadorned
'gnatmake', which finds the newly-installed one in $prefix.  That attempts to
invoke plain unadorned 'gcc' unfortunately, which is the distro compiler
installed in /usr/bin, and not the newly installed $prefix/bin/gcc-4, resulting
in the following error:

> + host_gnatmake -gnatws macrosub.adb
> 
> GNATMAKE 4.5.0 20090707 (experimental)
> Copyright (C) 1995-2009, Free Software Foundation, Inc.
>   "macrosub.ali" being checked ...
>   -> "macrosub.ali" missing.
> gcc -c -gnatV -gnatws macrosub.adb
> gnat1: invalid switch: -gnatea
> End of compilation

I tried hacking host_gnatmake and host_gnatchop to pass --GCC=gcc-4, but that
only got me a little way further:

> + host_gnatmake -gnatws macrosub.adb
> 
> GNATMAKE 4.5.0 20090707 (experimental)
> Copyright (C) 1995-2009, Free Software Foundation, Inc.
>   "macrosub.ali" being checked ...
>   -> "macrosub.ali" missing.
> gcc-4 -c -gnatws macrosub.adb
>   "defs.ali" being checked ...
>   -> "defs.ali" missing.
> gcc-4 -c -gnatws defs.ads
>   "getsubs.ali" being checked ...
>   -> "getsubs.ali" missing.
> gcc-4 -c -gnatws getsubs.adb
>   "parsemac.ali" being checked ...
>   -> "parsemac.ali" missing.
> gcc-4 -c -gnatws parsemac.adb
>   "text_io.ali" is a read-only library
> End of compilation
> gnatbind -x macrosub.ali
> gnatlink macrosub.ali
> b~macrosub.o:b~macrosub.adb:(.eh_frame+0x11): undefined reference to `___gnat_eh
> _personality'
> collect2: ld returned 1 exit status
> gnatlink: error when calling /usr/bin/gcc.exe
> gnatmake: *** link failed.

... the problem being that yet again the unsuffixed system compiler has been
invoked, and it's using the system runtime libs rather than the ones that go
with the newly-built compiler in $prefix (and which happen to be ABI
incompatible because they use ZCX instead of SJLJ).

  Should gnatmake have passed down the --GCC= option to gnatbind and gnatlink?


-- 

davek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|dave dot korn dot cygwin at |davek at gcc dot gnu dot org
                   |gmail dot com               |
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
            Version|2.95.2                      |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #12 from charlet at gcc dot gnu dot org  2008-05-29 09:04 -------
*** Bug 33857 has been marked as a duplicate of this bug. ***


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #11 from charlet at gcc dot gnu dot org  2008-05-29 08:59 -------
Fixed.


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #10 from charlet at gcc dot gnu dot org  2008-05-29 08:56 -------
Subject: Bug 864

Author: charlet
Date: Thu May 29 08:56:01 2008
New Revision: 136149

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=136149
Log:
        PR ada/864
        * osint.ads, osint.adb (Program_Name): New parameter "Prog" to
        allow recognition of program suffix in addition to prefix.

        * gnatchop.adb (Locate_Executable): Add support for prefix.

        * make.adb, gnatcmd.adb, gnatlink.adb, prj-makr.adb,
        mlib-utl.adb: Adjust calls to Program_Name.

Modified:
    trunk/gcc/ada/gnatchop.adb
    trunk/gcc/ada/gnatcmd.adb
    trunk/gcc/ada/gnatlink.adb
    trunk/gcc/ada/make.adb
    trunk/gcc/ada/mlib-utl.adb
    trunk/gcc/ada/osint.adb
    trunk/gcc/ada/osint.ads
    trunk/gcc/ada/prj-makr.adb


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #9 from charlet at gcc dot gnu dot org  2008-05-13 13:40 -------
Assigning to myself.


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |charlet at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #8 from charlet at gcc dot gnu dot org  2008-05-13 13:39 -------
*** Bug 29127 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[charlet at gcc dot gnu dot org]

------- Comment #7 from charlet at gcc dot gnu dot org  2008-05-12 23:42 -------
*** Bug 29127 has been marked as a duplicate of this bug. ***


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schwab at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864

[Bug ada/864] --program-suffix is ignored (for ada)

[ludovic dot brenta at insalien dot org]

------- Additional Comments From ludovic dot brenta at insalien dot org  2004-03-16 17:05 -------
The file gcc/ada/osint.adb contains code in function Program_Name (around line 
1463) which prevents renaming the executables if the program prefix or suffix 
contains a hyphen (-).

This code examines the name of the gnatmake executable and, if it contains a 
hyphen, it flags the compiler as being a cross-compiler, and changes the name
of the gcc compiler to use the same prefix.  For example, I tried renaming
gnatmake to gnatmake-3.3 and gcc to gcc-3.3, and got this:

make diners GNATMAKE=gnatmake-3.3
gnatmake-3.3 diners -cargs -O2
gnatmake-gcc-3.3 -c -O2 diners.adb                    [1]
gnatmake-3: error, unable to locate gnatmake-gcc-3.3  [2]
make: *** [diners] Error 4

The problem at line [1] is described above.

At line [2], GNAT also changed "gnatmake-3.3" to "gnatmake-3".  This
is because it assumes that everything after the last "." in the file
name is an extension, and removes it.  This is valid only on some hosts.
See osint.adb around line 797 in procedure Find_Program_Name.

-- 
Ludovic Brenta.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=864