public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/86723] not optimizing with bswap, that casts to int aftwards
Date: Thu, 19 Aug 2021 19:20:47 +0000	[thread overview]
Message-ID: <bug-86723-4-DxUTb0WOrP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-86723-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86723

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
It boils down to even simpler:
int
bar (unsigned long long value)
{
  return ((value & 0x000000ff00000000ull) >> 8)
         | ((value & 0x0000ff0000000000ull) >> 24)
         | ((value & 0x00ff000000000000ull) >> 40)
         | ((value & 0xff00000000000000ull) >> 56);
}
which is what you get from #c2 after optimizations.
The bswap pass tries to ATM recognize just nops - 0x0807060504030201
permutation
markers - and full bswaps - 0x0102030405060708 permutations, where in those
permutation bytes
   0       - target byte has the value 0
   FF      - target byte has an unknown value (eg. due to sign extension)
   1..size - marker value is the byte index in the source (0 for lsb).
But we could very well handle also masked bswaps, either just those one can get
from zero extensions, so 0x0000000005060708 or 0x0000000000000708 etc., or
generally with clearing of arbitrary bytes in it, say
0x0100030400060700 by doing __builtin_bswap64 (arg) & 0xff00ffff00ffff00ULL
etc.
Then this optimization would fall out from that, because we'd do
(int) (__builtin_bswap64 (arg) & 0xffffffffULL) and further opts would optimize
away the masking.

  parent reply	other threads:[~2021-08-19 19:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-86723-4@http.gcc.gnu.org/bugzilla/>
2021-08-19 18:42 ` pinskia at gcc dot gnu.org
2021-08-19 19:20 ` jakub at gcc dot gnu.org [this message]
2021-08-20 15:38 ` jakub at gcc dot gnu.org
2021-08-23  9:54 ` cvs-commit at gcc dot gnu.org
2021-08-23  9:54 ` jakub at gcc dot gnu.org
2021-08-25  2:35 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-86723-4-DxUTb0WOrP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).