From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id BB0B7385DC17; Fri, 27 Oct 2023 08:39:47 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB0B7385DC17
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1698395987;
	bh=UkR1LIwl2JaELV9DQ9Kwegrop+1s8uHt9oqLOCkjgkk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=HrQrmwcOvKPsj9/xjlRuGHpthPCtLbtVCm0AFns6PxMRYS0qZJmJtKUOfnbefcCSd
	 tZxn4DnYTSyIsGSi0p4k21xRfhl87d+NwFjNcb0I8pvkV+CXr8azAhCxBJzMygfwyg
	 VV/pA9arsfFMoT4XRfB2SaAGDK3rsu9zrcIruHC0=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug preprocessor/87299] #pragma GCC target behaves differently when
 using -save-temps
Date: Fri, 27 Oct 2023 08:39:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: preprocessor
X-Bugzilla-Version: 8.2.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-87299-4-J9zeOdhDnH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-87299-4@http.gcc.gnu.org/bugzilla/>
References: <bug-87299-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D87299

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Lewis Hyatt <lhyatt@gcc.gnu.org>:

https://gcc.gnu.org/g:8697d3a1dcf32750a3b9dc007586eb5f9ba5f17a

commit r14-4967-g8697d3a1dcf32750a3b9dc007586eb5f9ba5f17a
Author: Lewis Hyatt <lhyatt@gmail.com>
Date:   Fri Oct 27 04:32:50 2023 -0400

    preprocessor: c++: Support `#pragma GCC target' macros [PR87299]

    `#pragma GCC target' is not currently handled in preprocess-only mode
(e.g.,
    when running gcc -E or gcc -save-temps). As noted in the PR, this means
that
    if the target pragma defines any macros, those macros are not effective=
 in
    preprocess-only mode. Similarly, such macros are not effective when
    compiling with C++ (even when compiling without -save-temps), because C=
++
    does not process the pragma until after all tokens have been obtained f=
rom
    libcpp, at which point it is too late for macro expansion to take place.

    Since r13-1544 and r14-2893, there is a general mechanism to handle pra=
gmas
    under these conditions as well, so resolve the PR by using the new "ear=
ly
    pragma" support.

    toplev.cc required some changes because the target-specific handlers for
    `#pragma GCC target' may call target_reinit(), and toplev.cc was not
expecting
    that function to be called in preprocess-only mode.

    I added some additional testcases from the PR for x86. The other targets
    that support `#pragma GCC target' (aarch64, arm, nios2, powerpc, s390)
    already had tests verifying that the pragma sets macros as expected; he=
re I
    have added -save-temps versions of some of them, to test that they now =
work
    in preprocess-only mode as well.

    gcc/c-family/ChangeLog:

            PR preprocessor/87299
            * c-pragma.cc (init_pragma): Register `#pragma GCC target' and
            related pragmas in preprocess-only mode, and enable early handl=
ing.
            (c_reset_target_pragmas): New function refactoring code from...
            (handle_pragma_reset_options): ...here.
            * c-pragma.h (c_reset_target_pragmas): Declare.

    gcc/cp/ChangeLog:

            PR preprocessor/87299
            * parser.cc (cp_lexer_new_main): Call c_reset_target_pragmas ()
            after preprocessing is complete, before starting compilation.

    gcc/ChangeLog:

            PR preprocessor/87299
            * toplev.cc (no_backend): New static global.
            (finalize): Remove argument no_backend, which is now a
            static global.
            (process_options): Likewise.
            (do_compile): Likewise.
            (target_reinit): Don't do anything in preprocess-only mode.
            (toplev::main): Adapt to no_backend change.
            (toplev::finalize): Likewise.

    gcc/testsuite/ChangeLog:

            PR preprocessor/87299
            * c-c++-common/pragma-target-1.c: New test.
            * c-c++-common/pragma-target-2.c: New test.
            * g++.target/i386/pr87299-1.C: New test.
            * g++.target/i386/pr87299-2.C: New test.
            * gcc.target/i386/pr87299-1.c: New test.
            * gcc.target/i386/pr87299-2.c: New test.
            * gcc.target/s390/target-attribute/tattr-2b.c: New test.
            * gcc.target/aarch64/pragma_cpp_predefs_1b.c: New test.
            * gcc.target/arm/pragma_arch_attribute_1b.c: New test.
            * gcc.target/nios2/custom-fp-2b.c: New test.
            * gcc.target/powerpc/float128-3b.c: New test.=