public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/87504] inconsistent diagnostic style between C and C++ for binary operators
[not found] <bug-87504-4@http.gcc.gnu.org/bugzilla/>
@ 2021-11-12 12:00 ` egallager at gcc dot gnu.org
2022-05-16 1:21 ` egallager at gcc dot gnu.org
2023-08-08 22:21 ` egallager at gcc dot gnu.org
2 siblings, 0 replies; 3+ messages in thread
From: egallager at gcc dot gnu.org @ 2021-11-12 12:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87504
Eric Gallager <egallager at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |egallager at gcc dot gnu.org
--- Comment #9 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #8)
> Author: dmalcolm
> Date: Thu Dec 20 14:18:48 2018
> New Revision: 267299
>
> URL: https://gcc.gnu.org/viewcvs?rev=267299&root=gcc&view=rev
> Log:
> -Wtautological-compare: fix comparison of macro expansions
>
> gcc/c-family/ChangeLog:
> PR c++/87504
> * c-warn.c (get_outermost_macro_expansion): New function.
> (spelled_the_same_p): Use it to unwind the macro expansions, and
> compare the outermost macro in each nested expansion, rather than
> the innermost.
>
> gcc/testsuite/ChangeLog:
> PR c++/87504
> * c-c++-common/Wtautological-compare-8.c: New test.
>
>
> Added:
> trunk/gcc/testsuite/c-c++-common/Wtautological-compare-8.c
> Modified:
> trunk/gcc/c-family/ChangeLog
> trunk/gcc/c-family/c-warn.c
> trunk/gcc/testsuite/ChangeLog
so is this fixed now?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug c++/87504] inconsistent diagnostic style between C and C++ for binary operators
[not found] <bug-87504-4@http.gcc.gnu.org/bugzilla/>
2021-11-12 12:00 ` [Bug c++/87504] inconsistent diagnostic style between C and C++ for binary operators egallager at gcc dot gnu.org
@ 2022-05-16 1:21 ` egallager at gcc dot gnu.org
2023-08-08 22:21 ` egallager at gcc dot gnu.org
2 siblings, 0 replies; 3+ messages in thread
From: egallager at gcc dot gnu.org @ 2022-05-16 1:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87504
Eric Gallager <egallager at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |WAITING
--- Comment #10 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #9)
> (In reply to David Malcolm from comment #8)
> > Author: dmalcolm
> > Date: Thu Dec 20 14:18:48 2018
> > New Revision: 267299
> >
> > URL: https://gcc.gnu.org/viewcvs?rev=267299&root=gcc&view=rev
> > Log:
> > -Wtautological-compare: fix comparison of macro expansions
> >
> > gcc/c-family/ChangeLog:
> > PR c++/87504
> > * c-warn.c (get_outermost_macro_expansion): New function.
> > (spelled_the_same_p): Use it to unwind the macro expansions, and
> > compare the outermost macro in each nested expansion, rather than
> > the innermost.
> >
> > gcc/testsuite/ChangeLog:
> > PR c++/87504
> > * c-c++-common/Wtautological-compare-8.c: New test.
> >
> >
> > Added:
> > trunk/gcc/testsuite/c-c++-common/Wtautological-compare-8.c
> > Modified:
> > trunk/gcc/c-family/ChangeLog
> > trunk/gcc/c-family/c-warn.c
> > trunk/gcc/testsuite/ChangeLog
>
> so is this fixed now?
WAITING on a reply
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug c++/87504] inconsistent diagnostic style between C and C++ for binary operators
[not found] <bug-87504-4@http.gcc.gnu.org/bugzilla/>
2021-11-12 12:00 ` [Bug c++/87504] inconsistent diagnostic style between C and C++ for binary operators egallager at gcc dot gnu.org
2022-05-16 1:21 ` egallager at gcc dot gnu.org
@ 2023-08-08 22:21 ` egallager at gcc dot gnu.org
2 siblings, 0 replies; 3+ messages in thread
From: egallager at gcc dot gnu.org @ 2023-08-08 22:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87504
Eric Gallager <egallager at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|WAITING |RESOLVED
--- Comment #11 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #10)
> (In reply to Eric Gallager from comment #9)
> > (In reply to David Malcolm from comment #8)
> > > Author: dmalcolm
> > > Date: Thu Dec 20 14:18:48 2018
> > > New Revision: 267299
> > >
> > > URL: https://gcc.gnu.org/viewcvs?rev=267299&root=gcc&view=rev
> > > Log:
> > > -Wtautological-compare: fix comparison of macro expansions
> > >
> > > gcc/c-family/ChangeLog:
> > > PR c++/87504
> > > * c-warn.c (get_outermost_macro_expansion): New function.
> > > (spelled_the_same_p): Use it to unwind the macro expansions, and
> > > compare the outermost macro in each nested expansion, rather than
> > > the innermost.
> > >
> > > gcc/testsuite/ChangeLog:
> > > PR c++/87504
> > > * c-c++-common/Wtautological-compare-8.c: New test.
> > >
> > >
> > > Added:
> > > trunk/gcc/testsuite/c-c++-common/Wtautological-compare-8.c
> > > Modified:
> > > trunk/gcc/c-family/ChangeLog
> > > trunk/gcc/c-family/c-warn.c
> > > trunk/gcc/testsuite/ChangeLog
> >
> > so is this fixed now?
>
> WAITING on a reply
no reply; assuming this is fixed now. Feel free to reopen if there's still more
to do
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-08 22:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-87504-4@http.gcc.gnu.org/bugzilla/>
2021-11-12 12:00 ` [Bug c++/87504] inconsistent diagnostic style between C and C++ for binary operators egallager at gcc dot gnu.org
2022-05-16 1:21 ` egallager at gcc dot gnu.org
2023-08-08 22:21 ` egallager at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).