public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sbergman at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/87729] Please include -Woverloaded-virtual in -Wall
Date: Tue, 05 Jul 2022 08:17:21 +0000	[thread overview]
Message-ID: <bug-87729-4-KRPZMfUZyW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-87729-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87729

Stephan Bergmann <sbergman at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbergman at redhat dot com

--- Comment #10 from Stephan Bergmann <sbergman at redhat dot com> ---
(In reply to CVS Commits from comment #8)
> The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:
> 
> https://gcc.gnu.org/g:113844d68e94f4e9c0e946db351ba7d3d4a1335a
> 
> commit r13-1262-g113844d68e94f4e9c0e946db351ba7d3d4a1335a
> Author: Jason Merrill <jason@redhat.com>
> Date:   Fri Jun 24 14:40:12 2022 -0400
> 
>     c++: Include -Woverloaded-virtual in -Wall [PR87729]

This started to cause spurious -Woverloaded-virtual= warnings now (first
reported at <https://gcc.gnu.org/pipermail/gcc-patches/2022-July/597670.html>
"Re: [pushed] c++: Include -Woverloaded-virtual in -Wall [PR87729]"):

> $ cat test.cc
> struct S1 {};
> struct S2: S1 { virtual ~S2(); };
> struct S3 { virtual ~S3(); };
> struct S4: S2, S3 { virtual ~S4(); };

> $ g++ -Woverloaded-virtual -fsyntax-only test.cc
> test.cc:3:21: warning: ‘virtual S3::~S3()’ was hidden [-Woverloaded-virtual=]
>     3 | struct S3 { virtual ~S3(); };
>       |                     ^
> test.cc:4:29: note:   by ‘virtual S4::~S4()’
>     4 | struct S4: S2, S3 { virtual ~S4(); };
>       |                             ^
> test.cc:3:21: warning: ‘virtual S3::~S3()’ was hidden [-Woverloaded-virtual=]
>     3 | struct S3 { virtual ~S3(); };
>       |                     ^
> test.cc:4:29: note:   by ‘virtual S4::~S4()’
>     4 | struct S4: S2, S3 { virtual ~S4(); };
>       |                             ^
> test.cc:3:21: warning: ‘virtual S3::~S3()’ was hidden [-Woverloaded-virtual=]
>     3 | struct S3 { virtual ~S3(); };
>       |                     ^
> test.cc:4:29: note:   by ‘virtual S4::~S4()’
>     4 | struct S4: S2, S3 { virtual ~S4(); };
>       |                             ^

  parent reply	other threads:[~2022-07-05  8:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-87729-4@http.gcc.gnu.org/bugzilla/>
2020-08-07 14:48 ` xantares09 at hotmail dot com
2020-08-07 14:49 ` xantares09 at hotmail dot com
2020-09-21  0:04 ` egallager at gcc dot gnu.org
2022-06-24 19:34 ` jason at gcc dot gnu.org
2022-06-24 21:29 ` dblaikie at gmail dot com
2022-06-24 22:26 ` cvs-commit at gcc dot gnu.org
2022-06-24 22:28 ` jason at gcc dot gnu.org
2022-07-05  8:17 ` sbergman at redhat dot com [this message]
2022-07-07 16:00 ` cvs-commit at gcc dot gnu.org
2022-07-08  6:11 ` sbergman at redhat dot com
2022-07-25 13:23 ` cvs-commit at gcc dot gnu.org
2022-07-25 13:24 ` jason at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-87729-4-KRPZMfUZyW@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).