From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D380138618AB; Thu, 15 Feb 2024 11:44:13 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D380138618AB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1707997453;
	bh=+avhHhMIAhZFlqB8cau/D1SW68rm04ORCX0oBKG6PN4=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=jrkKu4oBrYH4Tub7B8dwI/pEoZ0gkpAW7sCZnAjbgJv63iooOAxrim0dIe8cvuQqo
	 G2RT4PFYd0Z6x8P7t9fPgXlSJOz6NNev6TMa/zKisvsy2y8dgrPAgEbhcuoD3cqsXa
	 xRVENdv3+u2X4VN98LPYBuCuuIq5yo6LwlBOzJFE=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/87744] Some valid instantiations of
 linear_congruential_engine produce compiler errors when __int128 isn't
 available
Date: Thu, 15 Feb 2024 11:44:08 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 7.3.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-87744-4-9GO1Arynt8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-87744-4@http.gcc.gnu.org/bugzilla/>
References: <bug-87744-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D87744

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:c9ce332b557bb95987d038d98ea929cdfd1eae1d

commit r14-8998-gc9ce332b557bb95987d038d98ea929cdfd1eae1d
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Feb 7 11:31:10 2024 +0000

    libstdc++: Use 128-bit arithmetic for std::linear_congruential_engine
[PR87744]

    For 32-bit targets without __int128 we need to implement the LCG
    transition function by hand using 64-bit types.

    We can also slightly simplify the __mod function by using if-constexpr
    unconditionally, disabling -Wc++17-extensions warnings with diagnostic
    pragmas.

    libstdc++-v3/ChangeLog:

            PR libstdc++/87744
            * include/bits/random.h [!__SIZEOF_INT128__]
(_Select_uint_least_t):
            Define specialization for 64-bit generators with
            non-power-of-two modulus and large constants.
            (__mod): Use if constexpr unconditionally.
            * testsuite/26_numerics/random/pr60037-neg.cc: Adjust dg-error
            line number.
            * testsuite/26_numerics/random/linear_congruential_engine/87744=
.cc:
            New test.=