public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/87744] Some valid instantiations of linear_congruential_engine produce compiler errors when __int128 isn't available
Date: Wed, 07 Feb 2024 10:38:41 +0000 [thread overview]
Message-ID: <bug-87744-4-YdjvUVyslZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-87744-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87744
--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #11)
> Though, if it is common enough, one could try to optimize the __ll[0] == 0
> && __xx[0] == 0 case, one can do then either 32x32->64 or 64x64->64
> multiplication and be done with it. But if it is rare in random's usage, it
> would just make the code larger.
We will only use this new type when the calculation a*(m-1)+c doesn't fit in 64
bits, and the input values should be uniformly distributed in [0,m) for a good
choice of parameters (and for a bad choice of parameters, you have bigger
problems than the calculation being slow!)
For a small value of a and large value of c we would use this new type but the
multiplication step would overflow infrequently, but I don't think that's a
good choice of parameters and not worth optimizing for.
So I think we should just use the full 64x64 multiplication unconditionally.
For operator% the if (__l._M_hi == 0) branch is probably worth it, because the
general case is so much more expensive.
next prev parent reply other threads:[~2024-02-07 10:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-87744-4@http.gcc.gnu.org/bugzilla/>
2024-02-06 21:09 ` redi at gcc dot gnu.org
2024-02-06 21:21 ` redi at gcc dot gnu.org
2024-02-06 21:28 ` redi at gcc dot gnu.org
2024-02-06 21:32 ` jakub at gcc dot gnu.org
2024-02-06 21:46 ` redi at gcc dot gnu.org
2024-02-06 21:48 ` redi at gcc dot gnu.org
2024-02-06 21:51 ` redi at gcc dot gnu.org
2024-02-06 21:51 ` jakub at gcc dot gnu.org
2024-02-06 22:04 ` redi at gcc dot gnu.org
2024-02-06 22:12 ` jakub at gcc dot gnu.org
2024-02-06 22:14 ` jakub at gcc dot gnu.org
2024-02-07 10:14 ` lrflew.coll at gmail dot com
2024-02-07 10:38 ` redi at gcc dot gnu.org [this message]
2024-02-07 10:55 ` redi at gcc dot gnu.org
2024-02-15 11:44 ` cvs-commit at gcc dot gnu.org
2024-02-16 10:52 ` cvs-commit at gcc dot gnu.org
2024-02-16 19:12 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-87744-4-YdjvUVyslZ@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).