public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/87744] Some valid instantiations of linear_congruential_engine produce compiler errors when __int128 isn't available Date: Tue, 06 Feb 2024 21:28:11 +0000 [thread overview] Message-ID: <bug-87744-4-ZFkFPvV1qi@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-87744-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87744 --- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> --- Based on that, I'm not sure what libc++ does is actually better than what libstdc++ does today (i.e. refuse to compile if the results would be wrong). I think the patch above would make sense though. I'm sure it could be optimized, I was more concerned with getting the results right than with performance. The first loop in operator% could just be a single left shift by the difference in the number of leading zeros between __l and __x. And halve() should just be a right shift (and "halve" isn't a reserved name).
next prev parent reply other threads:[~2024-02-06 21:28 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-87744-4@http.gcc.gnu.org/bugzilla/> 2024-02-06 21:09 ` redi at gcc dot gnu.org 2024-02-06 21:21 ` redi at gcc dot gnu.org 2024-02-06 21:28 ` redi at gcc dot gnu.org [this message] 2024-02-06 21:32 ` jakub at gcc dot gnu.org 2024-02-06 21:46 ` redi at gcc dot gnu.org 2024-02-06 21:48 ` redi at gcc dot gnu.org 2024-02-06 21:51 ` redi at gcc dot gnu.org 2024-02-06 21:51 ` jakub at gcc dot gnu.org 2024-02-06 22:04 ` redi at gcc dot gnu.org 2024-02-06 22:12 ` jakub at gcc dot gnu.org 2024-02-06 22:14 ` jakub at gcc dot gnu.org 2024-02-07 10:14 ` lrflew.coll at gmail dot com 2024-02-07 10:38 ` redi at gcc dot gnu.org 2024-02-07 10:55 ` redi at gcc dot gnu.org 2024-02-15 11:44 ` cvs-commit at gcc dot gnu.org 2024-02-16 10:52 ` cvs-commit at gcc dot gnu.org 2024-02-16 19:12 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-87744-4-ZFkFPvV1qi@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).