From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id C87AB3833024; Wed, 11 Nov 2020 20:11:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C87AB3833024
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/88115] Incorrect result from alignof in templates, if also
 using __alignof__.
Date: Wed, 11 Nov 2020 20:11:44 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 8.2.1
X-Bugzilla-Keywords: ABI, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-88115-4-tfEs3pmkKQ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-88115-4@http.gcc.gnu.org/bugzilla/>
References: <bug-88115-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2020 20:11:44 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D88115

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:61827d5d9a5a09a8c05d5e41f95b03ebc6c43f61

commit r11-4925-g61827d5d9a5a09a8c05d5e41f95b03ebc6c43f61
Author: Patrick Palka <ppalka@redhat.com>
Date:   Wed Nov 11 14:43:39 2020 -0500

    c++: Correct the handling of alignof(expr) [PR88115]

    We're currently neglecting to set the ALIGNOF_EXPR_STD_P flag on an
    ALIGNOF_EXPR when its operand is an expression.  This leads to us
    handling alignof(expr) as if it were written __alignof__(expr), and
    returning the preferred alignment instead of the ABI alignment.  In the
    testcase below, this causes the first and third static_assert to fail on
    x86.

    gcc/cp/ChangeLog:

            PR c++/88115
            * cp-tree.h (cxx_sizeof_or_alignof_expr): Add bool parameter.
            * decl.c (fold_sizeof_expr): Pass false to
            cxx_sizeof_or_alignof_expr.
            * parser.c (cp_parser_unary_expression): Pass std_alignof to
            cxx_sizeof_or_alignof_expr.
            * pt.c (tsubst_copy): Pass false to cxx_sizeof_or_alignof_expr.
            (tsubst_copy_and_build): Pass std_alignof to
            cxx_sizeof_or_alignof_expr.
            * typeck.c (cxx_alignof_expr): Add std_alignof bool parameter
            and pass it to cxx_sizeof_or_alignof_type.  Set ALIGNOF_EXPR_ST=
D_P
            appropriately.
            (cxx_sizeof_or_alignof_expr): Add std_alignof bool parameter
            and pass it to cxx_alignof_expr.  Assert op is either
            SIZEOF_EXPR or ALIGNOF_EXPR.

    libcc1/ChangeLog:

            PR c++/88115
            * libcp1plugin.cc (plugin_build_unary_expr): Pass true to
            cxx_sizeof_or_alignof_expr.

    gcc/testsuite/ChangeLog:

            PR c++/88115
            * g++.dg/cpp0x/alignof6.C: New test.=