* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
@ 2022-02-21 6:27 ` asolokha at gmx dot com
2022-02-21 9:12 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: asolokha at gmx dot com @ 2022-02-21 6:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #25 from Arseny Solokha <asolokha at gmx dot com> ---
I cannot reproduce it anymore w/ gcc 12.0.1 20220220 snapshot
(g:e49508ac6b36adb8a2056c5a1fb6e0178de2439d).
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
2022-02-21 6:27 ` [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520 asolokha at gmx dot com
@ 2022-02-21 9:12 ` rguenth at gcc dot gnu.org
2022-02-21 9:24 ` asolokha at gmx dot com
` (7 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-02-21 9:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #26 from Richard Biener <rguenth at gcc dot gnu.org> ---
Let's declare it fixed. It will pop up sooner or later if it is still latent.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
2022-02-21 6:27 ` [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520 asolokha at gmx dot com
2022-02-21 9:12 ` rguenth at gcc dot gnu.org
@ 2022-02-21 9:24 ` asolokha at gmx dot com
2022-02-21 10:16 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: asolokha at gmx dot com @ 2022-02-21 9:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #27 from Arseny Solokha <asolokha at gmx dot com> ---
Does it make sense to commit the patch from comment 17 (or comment 18)
nonetheless?
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2022-02-21 9:24 ` asolokha at gmx dot com
@ 2022-02-21 10:16 ` rguenth at gcc dot gnu.org
2022-02-21 10:19 ` asolokha at gmx dot com
` (5 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-02-21 10:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|RESOLVED |REOPENED
Last reconfirmed|2018-11-21 00:00:00 |2022-02-21
Resolution|FIXED |---
--- Comment #28 from Richard Biener <rguenth at gcc dot gnu.org> ---
Huh, yes - I assumed that had been fixed. Segher? Can you please fix that GTY
bug?
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2022-02-21 10:16 ` rguenth at gcc dot gnu.org
@ 2022-02-21 10:19 ` asolokha at gmx dot com
2022-02-21 15:03 ` segher at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: asolokha at gmx dot com @ 2022-02-21 10:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #29 from Arseny Solokha <asolokha at gmx dot com> ---
Let me clarify: I cannot reproduce that ICE from comment 5 as well, but
probably because of the same underlying reason that "fixed" the ICE from
comment 0.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2022-02-21 10:19 ` asolokha at gmx dot com
@ 2022-02-21 15:03 ` segher at gcc dot gnu.org
2022-02-21 23:47 ` segher at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: segher at gcc dot gnu.org @ 2022-02-21 15:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #30 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #28)
> Huh, yes - I assumed that had been fixed. Segher? Can you please fix that
> GTY bug?
I'll look at it. It's over three years old, will need some testing etc.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2022-02-21 15:03 ` segher at gcc dot gnu.org
@ 2022-02-21 23:47 ` segher at gcc dot gnu.org
2022-02-22 7:14 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 10+ messages in thread
From: segher at gcc dot gnu.org @ 2022-02-21 23:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #31 from Segher Boessenkool <segher at gcc dot gnu.org> ---
A straightforward backport of that gives
In file included from /home/segher/src/gcc/gcc/config/rs6000/rs6000.cc:28765:
./gt-rs6000.h:143:6: error: 'atomic_update_decl' was not declared in this scope
143 | &atomic_update_decl,
| ^~~~~~~~~~~~~~~~~~
./gt-rs6000.h:145:13: error: 'atomic_update_decl' was not declared in this
scope
145 | sizeof (atomic_update_decl),
| ^~~~~~~~~~~~~~~~~~
./gt-rs6000.h:150:6: error: 'atomic_clear_decl' was not declared in this scope
150 | &atomic_clear_decl,
| ^~~~~~~~~~~~~~~~~
./gt-rs6000.h:152:13: error: 'atomic_clear_decl' was not declared in this scope
152 | sizeof (atomic_clear_decl),
| ^~~~~~~~~~~~~~~~~
./gt-rs6000.h:157:6: error: 'atomic_hold_decl' was not declared in this scope
157 | &atomic_hold_decl,
| ^~~~~~~~~~~~~~~~
./gt-rs6000.h:159:13: error: 'atomic_hold_decl' was not declared in this scope
159 | sizeof (atomic_hold_decl),
| ^~~~~~~~~~~~~~~~
Help?
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2022-02-21 23:47 ` segher at gcc dot gnu.org
@ 2022-02-22 7:14 ` rguenth at gcc dot gnu.org
2022-02-22 16:22 ` cvs-commit at gcc dot gnu.org
2022-02-22 16:25 ` segher at gcc dot gnu.org
9 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-02-22 7:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #32 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #31)
> A straightforward backport of that gives
>
> In file included from /home/segher/src/gcc/gcc/config/rs6000/rs6000.cc:28765:
> ./gt-rs6000.h:143:6: error: 'atomic_update_decl' was not declared in this
> scope
> 143 | &atomic_update_decl,
> | ^~~~~~~~~~~~~~~~~~
> ./gt-rs6000.h:145:13: error: 'atomic_update_decl' was not declared in this
> scope
> 145 | sizeof (atomic_update_decl),
> | ^~~~~~~~~~~~~~~~~~
> ./gt-rs6000.h:150:6: error: 'atomic_clear_decl' was not declared in this
> scope
> 150 | &atomic_clear_decl,
> | ^~~~~~~~~~~~~~~~~
> ./gt-rs6000.h:152:13: error: 'atomic_clear_decl' was not declared in this
> scope
> 152 | sizeof (atomic_clear_decl),
> | ^~~~~~~~~~~~~~~~~
> ./gt-rs6000.h:157:6: error: 'atomic_hold_decl' was not declared in this scope
> 157 | &atomic_hold_decl,
> | ^~~~~~~~~~~~~~~~
> ./gt-rs6000.h:159:13: error: 'atomic_hold_decl' was not declared in this
> scope
> 159 | sizeof (atomic_hold_decl),
> | ^~~~~~~~~~~~~~~~
>
> Help?
The issue is that the decls are inside
#ifdef RS6000_GLIBC_ATOMIC_FENV
...
#endif
but gengtype will unconditionally register the root, refering to the variables.
I suggest to remove the #ifdef guard and instead wrap the decls inside
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused"
..
#pragma GCC idagnostic pop
The C++ FE doesn't seem to allow ATTRIBUTE_UNUSED anywhere here and I guess
"fixing" gengtype isn't a thing you want to do ;)
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2022-02-22 7:14 ` rguenth at gcc dot gnu.org
@ 2022-02-22 16:22 ` cvs-commit at gcc dot gnu.org
2022-02-22 16:25 ` segher at gcc dot gnu.org
9 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-02-22 16:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
--- Comment #33 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Segher Boessenkool <segher@gcc.gnu.org>:
https://gcc.gnu.org/g:537c96588026aec09b9a00d6d0f3670f612428b5
commit r12-7346-g537c96588026aec09b9a00d6d0f3670f612428b5
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date: Tue Feb 22 15:49:09 2022 +0000
rs6000: Fix GC on rs6000.c decls for atomic handling (PR88134)
In PR88134 it is pointed out that we do not have GTY markup for some
variables we use for atomic. So, let's add that.
2022-02-22 Segher Boessenkool <segher@kernel.crashing.org>
PR target/88134
* config/rs6000/rs6000.cc (atomic_hold_decl, atomic_clear_decl,
atomic_update_decl): Add GTY markup.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug target/88134] ICE in create_component_ref_by_pieces_1, at tree-ssa-pre.c:2520
[not found] <bug-88134-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2022-02-22 16:22 ` cvs-commit at gcc dot gnu.org
@ 2022-02-22 16:25 ` segher at gcc dot gnu.org
9 siblings, 0 replies; 10+ messages in thread
From: segher at gcc dot gnu.org @ 2022-02-22 16:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88134
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #34 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Fixed on trunk. No backports planned. Thanks everyone!
^ permalink raw reply [flat|nested] 10+ messages in thread