public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/88309] [11/12/13/14 Regression] ICE: Floating point exception (in is_miss_rate_acceptable), target assigning alignent of 4 bits(!) to vector
Date: Tue, 09 Apr 2024 02:03:51 +0000	[thread overview]
Message-ID: <bug-88309-4-IWe56TJn5f@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-88309-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88309

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:26eb5f8fd173e2425ae7505528fc426de4b7e34c

commit r14-9850-g26eb5f8fd173e2425ae7505528fc426de4b7e34c
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Mon Apr 8 21:01:36 2024 -0500

    rs6000: Fix wrong align passed to build_aligned_type [PR88309]

    As the comments in PR88309 show, there are two oversights
    in rs6000_gimple_fold_builtin that pass align in bytes to
    build_aligned_type but which actually requires align in
    bits, it causes unexpected ICE or hanging in function
    is_miss_rate_acceptable due to zero align_unit value.

    This patch is to fix them by converting bytes to bits, add
    an assertion on positive align_unit value and notes function
    build_aligned_type requires align measured in bits in its
    function comment.

            PR target/88309

    Co-authored-by: Andrew Pinski <quic_apinski@quicinc.com>

    gcc/ChangeLog:

            * config/rs6000/rs6000-builtin.cc (rs6000_gimple_fold_builtin): Fix
            wrong align passed to function build_aligned_type.
            * tree-ssa-loop-prefetch.cc (is_miss_rate_acceptable): Add an
            assertion to ensure align_unit should be positive.
            * tree.cc (build_qualified_type): Update function comments.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/pr88309.c: New test.

  parent reply	other threads:[~2024-04-09  2:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-88309-4@http.gcc.gnu.org/bugzilla/>
2024-03-25 18:23 ` [Bug target/88309] " pinskia at gcc dot gnu.org
2024-03-31  8:26 ` [Bug target/88309] [11/12/13/14 Regression] " pinskia at gcc dot gnu.org
2024-04-02  8:36 ` linkw at gcc dot gnu.org
2024-04-02 14:36 ` pinskia at gcc dot gnu.org
2024-04-03  1:47 ` linkw at gcc dot gnu.org
2024-04-09  2:03 ` cvs-commit at gcc dot gnu.org [this message]
2024-04-25  2:35 ` cvs-commit at gcc dot gnu.org
2024-04-25  2:35 ` cvs-commit at gcc dot gnu.org
2024-04-25  5:09 ` cvs-commit at gcc dot gnu.org
2024-04-25  5:12 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-88309-4-IWe56TJn5f@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).