[Bug preprocessor/88424] Inserts newlines when preserving comments for a file using Windows newlines

[Bug preprocessor/88424] Inserts newlines when preserving comments for a file using Windows newlines

[peter0x44 at disroot dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88424

--- Comment #3 from Peter Damianov <peter0x44 at disroot dot org> ---
Looking in a hex editor, what gcc is doing is changing the CRLF to LFLF, there
is no CR in the output.

  /* If the file is using old-school Mac line endings (\r only),
     terminate with another \r, not an \n, so that we do not mistake
     the \r\n sequence for a single DOS line ending and erroneously
     issue the "No newline at end of file" diagnostic.  */
  if (to.len && to.text[to.len - 1] == '\r')
    to.text[to.len] = '\r';
  else
    to.text[to.len] = '\n';

I noticed this code, but commenting it out makes the compiler fail selftests.

I'll keep looking to see if I can find the code responsible for doing that.

[Bug preprocessor/88424] Inserts newlines when preserving comments for a file using Windows newlines

[peter0x44 at disroot dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88424

--- Comment #4 from Peter Damianov <peter0x44 at disroot dot org> ---
All of the non-commments are turned to LF line endings.

So it must be something specifically to do with comment processing.

[Bug preprocessor/88424] Inserts newlines when preserving comments for a file using Windows newlines

[peter0x44 at disroot dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88424

--- Comment #5 from Peter Damianov <peter0x44 at disroot dot org> ---
I checked clang's behavior, and it does CRLF -> LF from non-comments, but it
leaves them intact in comments. I'm not really sure if this behavior is worth
emulating or not. I think it would be better to remove the CR from the CRLF in
comments too.