[Bug tree-optimization/88713] Vectorized code slow vs. flang

[Bug tree-optimization/88713] Vectorized code slow vs. flang

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88713

--- Comment #57 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #56)
> (In reply to Thomas Koenig from comment #55)
> > (In reply to H.J. Lu from comment #45)
> > > Created attachment 45510 [details]
> > > An updated patch
> > 
> > HJ, do you plan on committing these?
> 
> We are collecting performance data before I submit it.

Do you have the performance data by now?

[Bug tree-optimization/88713] Vectorized code slow vs. flang

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88713

--- Comment #58 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Thomas Koenig from comment #57)
> (In reply to H.J. Lu from comment #56)
> > (In reply to Thomas Koenig from comment #55)
> > > (In reply to H.J. Lu from comment #45)
> > > > Created attachment 45510 [details]
> > > > An updated patch
> > > 
> > > HJ, do you plan on committing these?
> > 
> > We are collecting performance data before I submit it.
> 
> Do you have the performance data by now?

A patch is posted at

https://gcc.gnu.org/pipermail/gcc-patches/2020-June/549047.html

[Bug tree-optimization/88713] Vectorized code slow vs. flang

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88713

--- Comment #59 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:fab263ab0fc10ea08409b80afa7e8569438b8d28

commit r11-1970-gfab263ab0fc10ea08409b80afa7e8569438b8d28
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Jan 23 06:33:58 2019 -0800

    x86: Enable FMA in rsqrt<mode>2 expander

    Enable FMA in rsqrt<mode>2 expander and fold rsqrtv16sf2 expander into
    rsqrt<mode>2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER.
    Although it doesn't show performance change in our workloads, FMA can
    improve other workloads.

    gcc/

            PR target/88713
            * config/i386/i386-expand.c (ix86_emit_swsqrtsf): Enable FMA.
            * config/i386/sse.md (VF_AVX512VL_VF1_128_256): New.
            (rsqrt<mode>2): Replace VF1_128_256 with VF_AVX512VL_VF1_128_256.
            (rsqrtv16sf2): Removed.

    gcc/testsuite/

            PR target/88713
            * gcc.target/i386/pr88713-1.c: New test.
            * gcc.target/i386/pr88713-2.c: Likewise.

[Bug tree-optimization/88713] Vectorized code slow vs. flang

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88713

--- Comment #60 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:737355072af4cd0c24a4a8967e1485c1f3a80bfe

commit r11-2200-g737355072af4cd0c24a4a8967e1485c1f3a80bfe
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Jul 13 09:07:00 2020 -0700

    x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256

    Since ix86_emit_swsqrtsf shouldn't be called with DF vector modes, rename
    VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 and drop DF vector modes.

    gcc/

            PR target/96186
            PR target/88713
            * config/i386/sse.md (VF_AVX512VL_VF1_128_256): Renamed to ...
            (VF1_AVX512ER_128_256): This.  Drop DF vector modes.
            (rsqrt<mode>2): Replace VF_AVX512VL_VF1_128_256 with
            VF1_AVX512ER_128_256.

    gcc/testsuite/

            PR target/96186
            PR target/88713
            * gcc.target/i386/pr88713-3.c: New test.