From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id F3B1E388A00B; Thu,  2 Apr 2020 09:14:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3B1E388A00B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1585818891;
 bh=nAu75gJGDAfrdvB63WB1W1ODp+kL233D91n140pU9mw=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=cRQ3pC1gRJ34BUoMV3ATNQxcmKQddR+NLAS259WLkjJl3mTtMUQqxrurg/r5HA1g/
 GXL0Wu/26Xynqc5O1QhEovHyOSfdhpIk/NyDmqt8Xg6nZwRcVsZVEpspTob2YD2Zl5
 SZJdnE4SR++7srhF0Gyrt3TY+G0NVVC7J/6kfhDU=
From: "gjl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/89148] [AVR] Merge plugin to place C++ vtables in flash
 memory
Date: Thu, 02 Apr 2020 09:14:50 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 9.2.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gjl at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-89148-4-Kp0wOGlDv1@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-89148-4@http.gcc.gnu.org/bugzilla/>
References: <bug-89148-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Apr 2020 09:14:51 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D89148

--- Comment #2 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Some remarks:

1. There are AVR devices that don't support named address spaces.  You will=
 run
into ICEs with this approach. You'll have to disable it for respective avr
families.

2. The patch sets non-generic address-spaces for objects / types used in the
C++ front-end, and that front-end does not support named address-spaces.  H=
ow
is it ensured that all transformations that take place in the C++ front-end
handle ASes correctly / consistently?

3. In the case there are problems, the user should be able to switch the
feature off by a command-line option.  This option requires documentation, =
in
particular it's not an optimization option because it changes the ABI.

4. The plugin must be built / installed. So I'd expect some extensions to t=
he
build system like t-avr?=