public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "gcc@christoph-conrads.name" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/89979] subtract_with_carry_engine incorrect carry flag
Date: Tue, 31 Aug 2021 09:39:24 +0000	[thread overview]
Message-ID: <bug-89979-4-9wdWP8gCDH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-89979-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89979

--- Comment #4 from Christoph Conrads <gcc@christoph-conrads.name> ---
> LLVM's libc++ does not go into the 0 loop but still does not do a good job:

The subtract-with-carry PRNG is a simple PRNG, it has a very long period whose
length can be proved with elementary number theory but the randomness
properties of an SWC on its own are bad which is why you have to discard a lot
of values. For reference, std::ranlux48 uses about 11 out of 389 values and you
can detect (self-advertisement: it discards much less variates if you you use
my parameters: b=32, s=2, r=13, see
https://github.com/boostorg/random/issues/57).

Here are the random values are drawing 100 times:

114294 141465 4294632814 252684 106646 4294497449 475286

Here are the random values after drawing 1000 times:

3844519667 4029384828 773557245 3005408692 1891078342 2314767096 2602358454

After drawing 2000 times:

671901017 3735908022 2276383719 2942324048 2197640583 3544339665 2823890385

      parent reply	other threads:[~2021-08-31  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-89979-4@http.gcc.gnu.org/bugzilla/>
2021-08-22 21:46 ` pinskia at gcc dot gnu.org
2021-08-31  9:39 ` gcc@christoph-conrads.name [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-89979-4-9wdWP8gCDH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).