public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/90115] OpenACC: predetermined private levels for variables declared in blocks
Date: Fri, 28 Oct 2022 08:31:42 +0000 [thread overview]
Message-ID: <bug-90115-4-RdyqJkX3R2@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-90115-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90115
--- Comment #19 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Thomas Schwinge
<tschwinge@gcc.gnu.org>:
https://gcc.gnu.org/g:9b116c51a451995f1bae8fdac0748fcf3f06aafe
commit r12-8874-g9b116c51a451995f1bae8fdac0748fcf3f06aafe
Author: Julian Brown <julian@codesourcery.com>
Date: Wed Oct 12 20:44:57 2022 +0000
OpenACC: Don't gang-privatize artificial variables [PR90115]
This patch prevents compiler-generated artificial variables from being
treated as privatization candidates for OpenACC.
The rationale is that e.g. "gang-private" variables actually must be
shared by each worker and vector spawned within a particular gang, but
that sharing is not necessary for any compiler-generated variable (at
least at present, but no such need is anticipated either). Variables on
the stack (and machine registers) are already private per-"thread"
(gang, worker and/or vector), and that's fine for artificial variables.
We're restricting this to blocks, as we still need to understand what it
means for a 'DECL_ARTIFICIAL' to appear in a 'private' clause.
Several tests need their scan output patterns adjusted to compensate.
2022-10-14 Julian Brown <julian@codesourcery.com>
PR middle-end/90115
gcc/
* omp-low.cc (oacc_privatization_candidate_p): Artificial vars are
not
privatization candidates.
libgomp/
* testsuite/libgomp.oacc-fortran/declare-1.f90: Adjust scan output.
* testsuite/libgomp.oacc-fortran/host_data-5.F90: Likewise.
* testsuite/libgomp.oacc-fortran/if-1.f90: Likewise.
* testsuite/libgomp.oacc-fortran/print-1.f90: Likewise.
* testsuite/libgomp.oacc-fortran/privatized-ref-2.f90: Likewise.
Co-authored-by: Thomas Schwinge <thomas@codesourcery.com>
(cherry picked from commit 11e811d8e2f63667f60f73731bb934273f5882b8)
prev parent reply other threads:[~2022-10-28 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-90115-4@http.gcc.gnu.org/bugzilla/>
2021-04-15 17:20 ` tschwinge at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:54 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:55 ` cvs-commit at gcc dot gnu.org
2021-05-21 18:55 ` cvs-commit at gcc dot gnu.org
2021-05-22 8:38 ` cvs-commit at gcc dot gnu.org
2022-03-02 2:19 ` egallager at gcc dot gnu.org
2022-03-10 11:07 ` cvs-commit at gcc dot gnu.org
2022-03-10 11:07 ` cvs-commit at gcc dot gnu.org
2022-03-10 11:34 ` tschwinge at gcc dot gnu.org
2022-03-12 13:04 ` cvs-commit at gcc dot gnu.org
2022-03-17 7:54 ` cvs-commit at gcc dot gnu.org
2022-10-28 8:25 ` cvs-commit at gcc dot gnu.org
2022-10-28 8:31 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-90115-4-RdyqJkX3R2@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).