public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug d/90136] [d] Merge UDAs between function prototype and definitions
[not found] <bug-90136-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-12 11:58 ` jakub at gcc dot gnu.org
2020-03-22 18:01 ` ibuclaw at gdcproject dot org
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-03-12 11:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90136
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.3 |9.4
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 9.3.0 has been released, adjusting target milestone.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug d/90136] [d] Merge UDAs between function prototype and definitions
[not found] <bug-90136-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` [Bug d/90136] [d] Merge UDAs between function prototype and definitions jakub at gcc dot gnu.org
@ 2020-03-22 18:01 ` ibuclaw at gdcproject dot org
2020-03-31 22:13 ` cvs-commit at gcc dot gnu.org
2020-03-31 22:15 ` ibuclaw at gdcproject dot org
3 siblings, 0 replies; 4+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-03-22 18:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90136
Iain Buclaw <ibuclaw at gdcproject dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.4 |10.0
--- Comment #4 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Setting milestone to version 10, as it's a feature request that affects an
extension to the language, not the core language itself.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug d/90136] [d] Merge UDAs between function prototype and definitions
[not found] <bug-90136-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` [Bug d/90136] [d] Merge UDAs between function prototype and definitions jakub at gcc dot gnu.org
2020-03-22 18:01 ` ibuclaw at gdcproject dot org
@ 2020-03-31 22:13 ` cvs-commit at gcc dot gnu.org
2020-03-31 22:15 ` ibuclaw at gdcproject dot org
3 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-03-31 22:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90136
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:013fca64fc17ba646c3564eab52fac50f0751188
commit r10-7487-g013fca64fc17ba646c3564eab52fac50f0751188
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Thu Apr 18 09:50:56 2019 +0200
d: Merge UDAs between function prototype and definitions (PR90136)
This change fixes the symbol merging in get_symbol_decl to also consider
prototypes. This allows the ability to set user defined attributes on
the prototype of a function, which then get applied to the definition,
if found later in the compilation.
The lowering of UDAs to GCC attributes has been commonized into a single
function called apply_user_attributes.
gcc/d/ChangeLog:
PR d/90136
* d-attribs.cc: Include dmd/attrib.h.
(build_attributes): Redeclare as static.
(apply_user_attributes): New function.
* d-tree.h (class UserAttributeDeclaration): Remove.
(build_attributes): Remove.
(apply_user_attributes): Declare.
(finish_aggregate_type): Remove attrs argument.
* decl.cc (get_symbol_decl): Merge declaration prototypes with
definitions. Use apply_user_attributes.
* modules.cc (layout_moduleinfo_fields): Remove last argument to
finish_aggregate_type.
* typeinfo.cc (layout_classinfo_interfaces): Likewise.
* types.cc (layout_aggregate_members): Likewise.
(finish_aggregate_type): Remove attrs argument.
(TypeVisitor::visit (TypeEnum *)): Use apply_user_attributes.
(TypeVisitor::visit (TypeStruct *)): Remove last argument to
finish_aggregate_type. Use apply_user_attributes.
(TypeVisitor::visit (TypeClass *)): Likewise.
gcc/testsuite/ChangeLog:
PR d/90136
* gdc.dg/pr90136a.d: New test.
* gdc.dg/pr90136b.d: New test.
* gdc.dg/pr90136c.d: New test.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug d/90136] [d] Merge UDAs between function prototype and definitions
[not found] <bug-90136-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-03-31 22:13 ` cvs-commit at gcc dot gnu.org
@ 2020-03-31 22:15 ` ibuclaw at gdcproject dot org
3 siblings, 0 replies; 4+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-03-31 22:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90136
Iain Buclaw <ibuclaw at gdcproject dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Done.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-31 22:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-90136-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` [Bug d/90136] [d] Merge UDAs between function prototype and definitions jakub at gcc dot gnu.org
2020-03-22 18:01 ` ibuclaw at gdcproject dot org
2020-03-31 22:13 ` cvs-commit at gcc dot gnu.org
2020-03-31 22:15 ` ibuclaw at gdcproject dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).