From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id E316E3858400; Mon, 20 Dec 2021 03:42:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E316E3858400 From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message Date: Mon, 20 Dec 2021 03:42:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 10.0 X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: normal X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: msebor at gcc dot gnu.org X-Bugzilla-Target-Milestone: 10.4 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 03:42:28 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D90524 --- Comment #4 from Andrew Pinski --- (In reply to Andrew Pinski from comment #3) > aarch64 error message is good: > :2:1: error: pragma or attribute 'target("foobar")' is not valid > 2 | __attribute__ ((target ("foobar"))) void foo () { } > | ^~~~~~~~~~~~~ arm is decent too: :2:1: error: unknown target attribute or pragma 'foobar' 2 | __attribute__ ((target ("foobar"))) void foo () { } | ^~~~~~~~~~~~~ Though I do think these diagnostic should be uniform rather than have forma= ts.=