* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-12 11:58 ` jakub at gcc dot gnu.org
2020-04-27 21:32 ` ibuclaw at gdcproject dot org
` (9 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-03-12 11:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.3 |9.4
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 9.3.0 has been released, adjusting target milestone.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris jakub at gcc dot gnu.org
@ 2020-04-27 21:32 ` ibuclaw at gdcproject dot org
2020-04-27 21:34 ` cvs-commit at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-04-27 21:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
--- Comment #4 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Patch is in upstream, syncing it down to gdc.
https://github.com/dlang/druntime/pull/3072
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris jakub at gcc dot gnu.org
2020-04-27 21:32 ` ibuclaw at gdcproject dot org
@ 2020-04-27 21:34 ` cvs-commit at gcc dot gnu.org
2020-04-27 21:59 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-27 21:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:6dffa67b46dc2d4deb25951f8b17e823f559cf3a
commit r10-8000-g6dffa67b46dc2d4deb25951f8b17e823f559cf3a
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Mon Apr 27 23:33:18 2020 +0200
libphobos: Backport extern(C) bindings from druntime 2.091
Merge upstream druntime 47688279.
Reviewed-on: https://github.com/dlang/druntime/pull/3073
Fixes: PR d/90718
Fixes: PR d/90719
libphobos/ChangeLog:
* libdruntime/Makefile.am (DRUNTIME_DSOURCES_LINUX): Remove
core/sys/linux/sys/netinet/tcp.d.
* libdruntime/Makefile.in: Regenerate.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-04-27 21:34 ` cvs-commit at gcc dot gnu.org
@ 2020-04-27 21:59 ` cvs-commit at gcc dot gnu.org
2020-04-27 22:01 ` ibuclaw at gdcproject dot org
` (6 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-27 21:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:1f0eba390fb5f887874e37a1f626eeab4ad55a44
commit r9-8547-g1f0eba390fb5f887874e37a1f626eeab4ad55a44
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Mon Apr 27 23:40:48 2020 +0200
libphobos: Fix struct layout of stat32_t on sparc-*-solaris*
Solaris 11 <sys/stat.h> has:
struct stat {
...
#if _FILE_OFFSET_BITS != 64
long st_pad3;
#endif
...
};
In the extern(C) core.sys bindings, st_pad3 is included in the
non-largefie version of struct stat when it shouldn't be.
libphobos/ChangeLog:
PR d/90719
* libdruntime/core/sys/posix/sys/stat.d (Solaris): Remove st_pad3
from
struct stat32_t.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-04-27 21:59 ` cvs-commit at gcc dot gnu.org
@ 2020-04-27 22:01 ` ibuclaw at gdcproject dot org
2020-04-29 9:27 ` ro at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-04-27 22:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
Iain Buclaw <ibuclaw at gdcproject dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Done.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2020-04-27 22:01 ` ibuclaw at gdcproject dot org
@ 2020-04-29 9:27 ` ro at gcc dot gnu.org
2020-04-29 10:21 ` ibuclaw at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: ro at gcc dot gnu.org @ 2020-04-29 9:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Ever confirmed|0 |1
Status|RESOLVED |REOPENED
Last reconfirmed| |2020-04-29
--- Comment #8 from Rainer Orth <ro at gcc dot gnu.org> ---
Unfortunately, something went wrong here: while my original patch removed
st_pad3
from the non-D_LP64 struct stat64_t, yours changed stat32_t instead, which
leaves
the affected test broken:
FAIL: libphobos.phobos_shared/std/file.d execution test
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2020-04-29 9:27 ` ro at gcc dot gnu.org
@ 2020-04-29 10:21 ` ibuclaw at gcc dot gnu.org
2020-04-29 10:56 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (3 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: ibuclaw at gcc dot gnu.org @ 2020-04-29 10:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
ibuclaw at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ibuclaw at gcc dot gnu.org
--- Comment #9 from ibuclaw at gcc dot gnu.org ---
(In reply to Rainer Orth from comment #8)
> Unfortunately, something went wrong here: while my original patch removed
> st_pad3
> from the non-D_LP64 struct stat64_t, yours changed stat32_t instead, which
> leaves
> the affected test broken:
>
> FAIL: libphobos.phobos_shared/std/file.d execution test
Oops, I must have both misunderstood your original bug report (you mentioned
stat32_t) *and* the patch applied against the wrong struct.
Fix sent here: https://github.com/dlang/druntime/pull/3078
I'll downstream it (again) as soon as it's in.
For GCC-11, I should really finish off some automated C header -> D conversion
tool, as you know all too well the pains of maintaining the current stdc and
sys packages in D runtime.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2020-04-29 10:21 ` ibuclaw at gcc dot gnu.org
@ 2020-04-29 10:56 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-04-30 10:16 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2020-04-29 10:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
--- Comment #10 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #9 from ibuclaw at gcc dot gnu.org ---
> (In reply to Rainer Orth from comment #8)
[...]
> Oops, I must have both misunderstood your original bug report (you mentioned
> stat32_t) *and* the patch applied against the wrong struct.
True, and the patch I'd attached didn't have enough context to fully see
which struct it applied to.
> Fix sent here: https://github.com/dlang/druntime/pull/3078
>
> I'll downstream it (again) as soon as it's in.
Great, thanks.
> For GCC-11, I should really finish off some automated C header -> D conversion
> tool, as you know all too well the pains of maintaining the current stdc and
> sys packages in D runtime.
Excellent idea: gccgo already does this with good success.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2020-04-29 10:56 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2020-04-30 10:16 ` cvs-commit at gcc dot gnu.org
2020-05-16 20:54 ` cvs-commit at gcc dot gnu.org
2020-05-16 20:55 ` ibuclaw at gdcproject dot org
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-30 10:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:05b6520ed29a9e2b5480ecab4e71d999c7d04f29
commit r10-8066-g05b6520ed29a9e2b5480ecab4e71d999c7d04f29
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Thu Apr 30 11:03:33 2020 +0200
d: Merge upstream dmd 934df6f8c, druntime 7bdd83d7
Corrects a previous change made to the SPARC stdc bindings, and
backports PPC-related fixes. The library and language testsuite now
passes fully on powerpc64le-linux-gnu.
Fixes: PR d/90719
Fixes: PR d/94825
Reviewed-on: https://github.com/dlang/dmd/pull/11079
https://github.com/dlang/druntime/pull/3078
https://github.com/dlang/druntime/pull/3083
libphobos/ChangeLog:
PR d/94825
* libdruntime/Makefile.am (DRUNTIME_SOURCES_CONFIGURED): Remove
config/powerpc/switchcontext.S
* libdruntime/Makefile.in: Regenerate.
* libdruntime/config/powerpc/callwithstack.S: Remove.
* libdruntime/config/powerpc/switchcontext.S: Fix symbol name of
fiber_switchContext.
* libdruntime/core/thread.d: Disable fiber migration tests on PPC.
* testsuite/libphobos.thread/fiber_guard_page.d: Set guardPageSize
same as stackSize.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2020-04-30 10:16 ` cvs-commit at gcc dot gnu.org
@ 2020-05-16 20:54 ` cvs-commit at gcc dot gnu.org
2020-05-16 20:55 ` ibuclaw at gdcproject dot org
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-05-16 20:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:866f7405707dd2970868941635a32bd9197cd731
commit r9-8598-g866f7405707dd2970868941635a32bd9197cd731
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Sat May 16 22:32:17 2020 +0200
libphobos: Fix struct layout of stat_t on sparc-*-solaris*
The last change to the bindings removed the st_pad3 field from the wrong
struct. It should have been stat64_t that needed updating instead.
libphobos/ChangeLog
PR d/90719
* libdruntime/core/sys/posix/sys/stat.d (Solaris): Move st_pad3
from
struct stat64_t to stat32_t.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug d/90719] libphobos.phobos_shared/std/file.d FAILs on 32-bit Solaris
[not found] <bug-90719-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2020-05-16 20:54 ` cvs-commit at gcc dot gnu.org
@ 2020-05-16 20:55 ` ibuclaw at gdcproject dot org
10 siblings, 0 replies; 11+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-05-16 20:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90719
Iain Buclaw <ibuclaw at gdcproject dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #13 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Now should be resolved for good.
^ permalink raw reply [flat|nested] 11+ messages in thread