* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
@ 2021-07-18 7:08 ` pinskia at gcc dot gnu.org
2021-08-20 14:16 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-07-18 7:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |akhilesh.k at samsung dot com
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 81480 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
2021-07-18 7:08 ` [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported pinskia at gcc dot gnu.org
@ 2021-08-20 14:16 ` cvs-commit at gcc dot gnu.org
2021-08-20 14:16 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-20 14:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:29b2fd371f18169141e20b90effa7205db68fb11
commit r12-3045-g29b2fd371f18169141e20b90effa7205db68fb11
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Aug 20 14:51:06 2021 +0100
libstdc++: Skip filesystem tests that depend on permissions [PR90787]
Tests that depend on filesystem permissions FAIL if run on Windows or as
root. Add a helper function to detect those cases, so the tests can skip
those checks gracefully.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/90787
* testsuite/27_io/filesystem/iterators/directory_iterator.cc:
Use new __gnu_test::permissions_are_testable() function.
*
testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/27_io/filesystem/operations/exists.cc: Likewise.
* testsuite/27_io/filesystem/operations/is_empty.cc: Likewise.
* testsuite/27_io/filesystem/operations/remove.cc: Likewise.
* testsuite/27_io/filesystem/operations/remove_all.cc: Likewise.
* testsuite/27_io/filesystem/operations/status.cc: Likewise.
* testsuite/27_io/filesystem/operations/symlink_status.cc:
Likewise.
* testsuite/27_io/filesystem/operations/temp_directory_path.cc:
Likewise.
*
testsuite/experimental/filesystem/iterators/directory_iterator.cc:
Likewise.
*
testsuite/experimental/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/experimental/filesystem/operations/exists.cc:
Likewise.
* testsuite/experimental/filesystem/operations/is_empty.cc:
Likewise.
* testsuite/experimental/filesystem/operations/remove.cc:
Likewise.
* testsuite/experimental/filesystem/operations/remove_all.cc:
Likewise.
*
testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Likewise.
* testsuite/util/testsuite_fs.h
(__gnu_test::permissions_are_testable):
New function to guess whether testing permissions will work.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
2021-07-18 7:08 ` [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported pinskia at gcc dot gnu.org
2021-08-20 14:16 ` cvs-commit at gcc dot gnu.org
@ 2021-08-20 14:16 ` redi at gcc dot gnu.org
2021-08-23 8:52 ` clyon at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2021-08-20 14:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |10.4
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk but I'll backport it too.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-08-20 14:16 ` redi at gcc dot gnu.org
@ 2021-08-23 8:52 ` clyon at gcc dot gnu.org
2021-08-23 13:46 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: clyon at gcc dot gnu.org @ 2021-08-23 8:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
Christophe Lyon <clyon at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |clyon at gcc dot gnu.org
--- Comment #5 from Christophe Lyon <clyon at gcc dot gnu.org> ---
After r12-3045, I see regressions on bare-metal, newlib based targets
(arm-eabi, aarch64-elf):
FAIL: 27_io/filesystem/path/append/path.cc (test for excess errors)
Excess errors:
/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-eabi/bin/ld: /ccrhrvyi.o: in
function `_ZN10__gnu_test24permissions_are_testableEb':
/libstdc++-v3/testsuite/util/testsuite_fs.h:168: undefined reference to
`geteuid'
collect2: error: ld returned 1 exit status
UNRESOLVED: 27_io/filesystem/path/append/path.cc compilation failed to produce
executable
48 tests have a similar error:
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/append/path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/append/source.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/assign/assign.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/assign/copy.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/compare/compare.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/compare/lwg2936.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/compare/path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/compare/strings.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/concat/92853.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/concat/path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/concat/strings.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/construct/copy.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/construct/range.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/construct/string_view.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/extension.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/filename.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/parent_path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/relative_path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/root_directory.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/root_name.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/root_path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/decompose/stem.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/generation/normal.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/generation/proximate.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/generation/relative.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/generic/generic_string.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/itr/components.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/itr/traversal.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/modifiers/clear.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/modifiers/make_preferred.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/modifiers/remove_filename.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/modifiers/replace_extension.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/modifiers/replace_filename.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/modifiers/swap.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/nonmember/append.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/nonmember/cmp.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/nonmember/cmp_c++20.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/nonmember/hash_value.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/empty.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_extension.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_filename.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_parent_path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_relative_path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_root_directory.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_root_name.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_root_path.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/has_stem.cc
(test for excess errors)
libstdc++:libstdc++-dg/conformance.exp=27_io/filesystem/path/query/is_relative.cc
(test for excess errors)
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-08-23 8:52 ` clyon at gcc dot gnu.org
@ 2021-08-23 13:46 ` cvs-commit at gcc dot gnu.org
2021-10-12 19:40 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-23 13:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:bc97e736a5597ac1545b7f9069472117b6caa867
commit r12-3081-gbc97e736a5597ac1545b7f9069472117b6caa867
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Mon Aug 23 13:05:25 2021 +0100
libstdc++: Make permissions_are_testable function inline [PR90787]
This function should be inline, so that's it's not emitted in tests that
don't use it, to avoid undefined references to geteuid().
libstdc++-v3/ChangeLog:
PR libstdc++/90787
* testsuite/util/testsuite_fs.h (permissions_are_testable):
Define as inline.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2021-08-23 13:46 ` cvs-commit at gcc dot gnu.org
@ 2021-10-12 19:40 ` cvs-commit at gcc dot gnu.org
2021-10-13 15:29 ` cvs-commit at gcc dot gnu.org
2021-10-13 17:07 ` redi at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-12 19:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:cec047eaeb3ca40be65500d140a3a3f16db742e1
commit r11-9133-gcec047eaeb3ca40be65500d140a3a3f16db742e1
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Aug 20 14:51:06 2021 +0100
libstdc++: Skip filesystem tests that depend on permissions [PR90787]
Tests that depend on filesystem permissions FAIL if run on Windows or as
root. Add a helper function to detect those cases, so the tests can skip
those checks gracefully.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/90787
* testsuite/27_io/filesystem/iterators/directory_iterator.cc:
Use new __gnu_test::permissions_are_testable() function.
*
testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/27_io/filesystem/operations/exists.cc: Likewise.
* testsuite/27_io/filesystem/operations/is_empty.cc: Likewise.
* testsuite/27_io/filesystem/operations/remove.cc: Likewise.
* testsuite/27_io/filesystem/operations/remove_all.cc: Likewise.
* testsuite/27_io/filesystem/operations/status.cc: Likewise.
* testsuite/27_io/filesystem/operations/symlink_status.cc:
Likewise.
* testsuite/27_io/filesystem/operations/temp_directory_path.cc:
Likewise.
*
testsuite/experimental/filesystem/iterators/directory_iterator.cc:
Likewise.
*
testsuite/experimental/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/experimental/filesystem/operations/exists.cc:
Likewise.
* testsuite/experimental/filesystem/operations/is_empty.cc:
Likewise.
* testsuite/experimental/filesystem/operations/remove.cc:
Likewise.
* testsuite/experimental/filesystem/operations/remove_all.cc:
Likewise.
*
testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Likewise.
* testsuite/util/testsuite_fs.h
(__gnu_test::permissions_are_testable):
New function to guess whether testing permissions will work.
(cherry picked from commit 29b2fd371f18169141e20b90effa7205db68fb11)
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2021-10-12 19:40 ` cvs-commit at gcc dot gnu.org
@ 2021-10-13 15:29 ` cvs-commit at gcc dot gnu.org
2021-10-13 17:07 ` redi at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-13 15:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:4be4888d6bddbcc106efeb19e18c380e7c1d041a
commit r10-10214-g4be4888d6bddbcc106efeb19e18c380e7c1d041a
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Aug 20 14:51:06 2021 +0100
libstdc++: Skip filesystem tests that depend on permissions [PR90787]
Tests that depend on filesystem permissions FAIL if run on Windows or as
root. Add a helper function to detect those cases, so the tests can skip
those checks gracefully.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/90787
* testsuite/27_io/filesystem/iterators/directory_iterator.cc:
Use new __gnu_test::permissions_are_testable() function.
*
testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/27_io/filesystem/operations/exists.cc: Likewise.
* testsuite/27_io/filesystem/operations/is_empty.cc: Likewise.
* testsuite/27_io/filesystem/operations/remove.cc: Likewise.
* testsuite/27_io/filesystem/operations/remove_all.cc: Likewise.
* testsuite/27_io/filesystem/operations/status.cc: Likewise.
* testsuite/27_io/filesystem/operations/symlink_status.cc:
Likewise.
* testsuite/27_io/filesystem/operations/temp_directory_path.cc:
Likewise.
*
testsuite/experimental/filesystem/iterators/directory_iterator.cc:
Likewise.
*
testsuite/experimental/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/experimental/filesystem/operations/exists.cc:
Likewise.
* testsuite/experimental/filesystem/operations/is_empty.cc:
Likewise.
* testsuite/experimental/filesystem/operations/remove.cc:
Likewise.
* testsuite/experimental/filesystem/operations/remove_all.cc:
Likewise.
*
testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Likewise.
* testsuite/util/testsuite_fs.h
(__gnu_test::permissions_are_testable):
New function to guess whether testing permissions will work.
(cherry picked from commit 29b2fd371f18169141e20b90effa7205db68fb11)
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libstdc++/90787] filesystem tests fail if file permissions are not supported
[not found] <bug-90787-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2021-10-13 15:29 ` cvs-commit at gcc dot gnu.org
@ 2021-10-13 17:07 ` redi at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2021-10-13 17:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90787
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 10.4 and 11.3
^ permalink raw reply [flat|nested] 8+ messages in thread