[Bug c++/90996] [8/9/10 Regression] ICE in gimplify_expr, at gimplify.c:13495

[Bug c++/90996] [8/9/10 Regression] ICE in gimplify_expr, at gimplify.c:13495

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppalka at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org

[Bug c++/90996] [8/9/10 Regression] ICE in gimplify_expr, at gimplify.c:13495

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:23f1f679141bbb4720ca195cb758605dc017b7fd

commit r10-7587-g23f1f679141bbb4720ca195cb758605dc017b7fd
Author: Patrick Palka <ppalka@redhat.com>
Date:   Mon Apr 6 14:05:44 2020 -0400

    c++: Fix usage of CONSTRUCTOR_PLACEHOLDER_BOUNDARY inside array
initializers [PR90996]

    This PR reports that ever since the introduction of the
    CONSTRUCTOR_PLACEHOLDER_BOUNDARY flag, we are sometimes failing to resolve
    PLACEHOLDER_EXPRs inside array initializers that refer to some inner
    constructor.  In the testcase in the PR, we have as the initializer for "S
c[];"
    the following

      {{.a=(int &) &_ZGR1c_, .b={*(&<PLACEHOLDER_EXPR struct S>)->a}}}

    where CONSTRUCTOR_PLACEHOLDER_BOUNDARY is set on the middle constructor. 
When
    calling replace_placeholders from store_init_value, we pass the entire
    initializer to it, and as a result we fail to resolve the PLACEHOLDER_EXPR
    within due to the CONSTRUCTOR_PLACEHOLDER_BOUNDARY flag on the middle
    constructor blocking replace_placeholders_r from reaching it.

    To fix this, we could perhaps either call replace_placeholders in more
places,
    or we could change where we set CONSTRUCTOR_PLACEHOLDER_BOUNDARY.  This
patch
    takes this latter approach -- when building up an array initializer, we now
    bubble any CONSTRUCTOR_PLACEHOLDER_BOUNDARY flag from the element
initializers
    up to the array initializer so that the boundary doesn't later impede us
when we
    call replace_placeholders from store_init_value.

    Besides fixing the kind of code like in the testcase, this shouldn't cause
any
    other differences in PLACEHOLDER_EXPR resolution because we don't create or
use
    PLACEHOLDER_EXPRs of array type in the frontend, as far as I can tell.

    gcc/cp/ChangeLog:

            PR c++/90996
            * tree.c (replace_placeholders): Look through all handled
components,
            not just COMPONENT_REFs.
            * typeck2.c (process_init_constructor_array): Propagate
            CONSTRUCTOR_PLACEHOLDER_BOUNDARY up from each element initializer
to
            the array initializer.

    gcc/testsuite/ChangeLog:

            PR c++/90996
            * g++.dg/cpp1y/pr90996.C: New test.

[Bug c++/90996] [8/9 Regression] ICE in gimplify_expr, at gimplify.c:13495

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10 Regression] ICE in  |[8/9 Regression] ICE in
                   |gimplify_expr, at           |gimplify_expr, at
                   |gimplify.c:13495            |gimplify.c:13495

--- Comment #5 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 10 so far.

[Bug c++/90996] [8/9 Regression] ICE in gimplify_expr, at gimplify.c:13495

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:289fbbe75f6d1c69605fcfde769ac46944c14a4a

commit r11-424-g289fbbe75f6d1c69605fcfde769ac46944c14a4a
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri May 15 14:50:17 2020 -0400

    c++: Revert unnecessary parts of fix for [PR90996]

    The process_init_constructor_array part of my PR90996 patch turns out to
    be neither necessary nor sufficient to make the pr90996.C testcase work,
    and I wasn't able to come up with a testcase that demonstrates this part
    is ever necessary.

    gcc/cp/ChangeLog:

            Revert:

            2020-04-07  Patrick Palka  <ppalka@redhat.com>

            PR c++/90996
            * typeck2.c (process_init_constructor_array): Propagate
            CONSTRUCTOR_PLACEHOLDER_BOUNDARY up from each element
            initializer to the array initializer.

    gcc/testsuite/ChangeLog:

            PR c++/90996
            * g++.dg/cpp1y/pr90996.C: Turn into execution test to verify
            that each PLACEHOLDER_EXPR gets correctly resolved.

[Bug c++/90996] [9 Regression] ICE in gimplify_expr, at gimplify.c:13495

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

[Bug c++/90996] [9 Regression] ICE in gimplify_expr, at gimplify.c:13495

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug c++/90996] [9 Regression] ICE in gimplify_expr, at gimplify.c:13495

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90996

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|9.5                         |10.0
      Known to fail|10.0                        |9.5.0

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed in GCC 10.