public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/91027] [10 regression] SEGV in hash_table<odr_name_hasher, false, xcallocator>::find_slot_with_hash
Date: Fri, 20 Mar 2020 16:26:45 +0000 [thread overview]
Message-ID: <bug-91027-4-z28FQT4Gmx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91027-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91027
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:b5446d0cc09e6a931065b98101d799711fd5b035
commit r10-7302-gb5446d0cc09e6a931065b98101d799711fd5b035
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Fri Mar 20 17:26:29 2020 +0100
d: Fix SEGV in hash_table<odr_name_hasher, false,
xcallocator>::find_slot_with_hash
This patch fixes LTO bug with the D front-end. As DECL_ASSEMBLER_NAME
is set on the TYPE_DECL, so TYPE_CXX_ODR_P must also be set on the type.
The addition of merge_aggregate_types is not strictly needed now, but it
fixes a problem introduced in newer versions of the dmd front-end where
templated types could be sent more than once to the D code generator.
gcc/d/ChangeLog:
2020-03-20 Iain Buclaw <ibuclaw@gdcproject.org>
PR lto/91027
* d-tree.h (struct GTY): Add daggregate field.
(IDENTIFIER_DAGGREGATE): Define.
(d_mangle_decl): Add declaration.
* decl.cc (mangle_decl): Remove static linkage, rename to...
(d_mangle_decl): ...this, update all callers.
* types.cc (merge_aggregate_types): New function.
(TypeVisitor::visit (TypeStruct *)): Call merge_aggregate_types,
set
IDENTIFIER_DAGGREGATE and TYPE_CXX_ODR_P.
(TypeVisitor::visit (TypeClass *)): Likewise.
next prev parent reply other threads:[~2020-03-20 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-91027-4@http.gcc.gnu.org/bugzilla/>
2020-03-17 19:11 ` ibuclaw at gdcproject dot org
2020-03-20 16:26 ` cvs-commit at gcc dot gnu.org [this message]
2020-03-20 16:28 ` ibuclaw at gcc dot gnu.org
2020-03-25 11:49 ` ro at gcc dot gnu.org
2020-04-01 17:13 ` ibuclaw at gdcproject dot org
2020-04-01 17:14 ` ibuclaw at gdcproject dot org
2020-04-01 17:16 ` ibuclaw at gdcproject dot org
2020-04-02 8:34 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-04-02 8:34 ` ro at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-91027-4-z28FQT4Gmx@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).