public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/91212] [8/9/10/11 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
@ 2020-07-29 18:25 ` cvs-commit at gcc dot gnu.org
2020-09-27 23:37 ` blubban at gmail dot com
` (5 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-07-29 18:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:
https://gcc.gnu.org/g:81bc0ec3e926d7a2c90502847ddaacf3d56d5b75
commit r11-2411-g81bc0ec3e926d7a2c90502847ddaacf3d56d5b75
Author: Jason Merrill <jason@redhat.com>
Date: Wed Jul 29 00:57:40 2020 -0400
c++: Avoid calling const copy ctor on implicit move. [PR91212]
Our implementation of C++11 implicit move was wrong for return; we didn't
actually hit the check for the type of the first parameter of the selected
constructor, because we didn't see LOOKUP_PREFER_RVALUE set properly.
Fixing that to look at the right flags fixed the issue for this testcase,
but broke implicit move for a by-value converting constructor (PR58051). I
think this was not allowed in C++17, but it is allowed under the implicit
move changes from C++20, and those changes were voted to apply as a DR to
earlier standards as well, so I don't want to break it now.
So after fixing the flags check I changed the test to allow value
parameters.
gcc/cp/ChangeLog:
PR c++/91212
* call.c (build_over_call): Don't call a const ref
overload for implicit move.
gcc/testsuite/ChangeLog:
PR c++/91212
* g++.dg/cpp0x/move-return3.C: New test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/91212] [8/9/10/11 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
2020-07-29 18:25 ` [Bug c++/91212] [8/9/10/11 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073 cvs-commit at gcc dot gnu.org
@ 2020-09-27 23:37 ` blubban at gmail dot com
2021-05-14 9:51 ` [Bug c++/91212] [9/10 " jakub at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: blubban at gmail dot com @ 2020-09-27 23:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
Alfred Agrell <blubban at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |blubban at gmail dot com
--- Comment #10 from Alfred Agrell <blubban at gmail dot com> ---
*** Bug 97221 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/91212] [9/10 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
2020-07-29 18:25 ` [Bug c++/91212] [8/9/10/11 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073 cvs-commit at gcc dot gnu.org
2020-09-27 23:37 ` blubban at gmail dot com
@ 2021-05-14 9:51 ` jakub at gcc dot gnu.org
2021-06-01 8:14 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-05-14 9:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|8.5 |9.4
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/91212] [9/10 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-05-14 9:51 ` [Bug c++/91212] [9/10 " jakub at gcc dot gnu.org
@ 2021-06-01 8:14 ` rguenth at gcc dot gnu.org
2022-05-27 9:41 ` [Bug c++/91212] [10 " rguenth at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-06-01 8:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.4 |9.5
--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/91212] [10 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-06-01 8:14 ` rguenth at gcc dot gnu.org
@ 2022-05-27 9:41 ` rguenth at gcc dot gnu.org
2022-06-28 10:38 ` jakub at gcc dot gnu.org
2023-03-07 17:43 ` mpolacek at gcc dot gnu.org
6 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-05-27 9:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.5 |10.4
--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/91212] [10 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2022-05-27 9:41 ` [Bug c++/91212] [10 " rguenth at gcc dot gnu.org
@ 2022-06-28 10:38 ` jakub at gcc dot gnu.org
2023-03-07 17:43 ` mpolacek at gcc dot gnu.org
6 siblings, 0 replies; 7+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-06-28 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.4 |10.5
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/91212] [10 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2022-06-28 10:38 ` jakub at gcc dot gnu.org
@ 2023-03-07 17:43 ` mpolacek at gcc dot gnu.org
6 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2023-03-07 17:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91212
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #15 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I don't think we want to backport this to GCC 10 at this point. Closing.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-07 17:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-91212-4@http.gcc.gnu.org/bugzilla/>
2020-07-29 18:25 ` [Bug c++/91212] [8/9/10/11 Regression] const ignored for ctor arguments within return since r8-2493-g4ce8c5dea53d8073 cvs-commit at gcc dot gnu.org
2020-09-27 23:37 ` blubban at gmail dot com
2021-05-14 9:51 ` [Bug c++/91212] [9/10 " jakub at gcc dot gnu.org
2021-06-01 8:14 ` rguenth at gcc dot gnu.org
2022-05-27 9:41 ` [Bug c++/91212] [10 " rguenth at gcc dot gnu.org
2022-06-28 10:38 ` jakub at gcc dot gnu.org
2023-03-07 17:43 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).