* [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support
[not found] <bug-91602-4@http.gcc.gnu.org/bugzilla/>
@ 2021-07-16 8:06 ` belyshev at depni dot sinp.msu.ru
2021-07-16 8:24 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: belyshev at depni dot sinp.msu.ru @ 2021-07-16 8:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91602
Serge Belyshev <belyshev at depni dot sinp.msu.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |belyshev at depni dot sinp.msu.ru
--- Comment #12 from Serge Belyshev <belyshev at depni dot sinp.msu.ru> ---
Testing a patch that removes in-tree gas version checks along with resulting
dead code.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support
[not found] <bug-91602-4@http.gcc.gnu.org/bugzilla/>
2021-07-16 8:06 ` [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support belyshev at depni dot sinp.msu.ru
@ 2021-07-16 8:24 ` jakub at gcc dot gnu.org
2021-07-19 14:40 ` wilson at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-07-16 8:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91602
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Note, on the DWARF side it has been agreed to get rid of the requirement that
uleb128/sleb128 has to be minimum possible length and I think all consumers
known to me will not mind non-minimal leb128 as long as it isn't padded too
much (i.e. fits within 10 bytes or so). So, even heavy relaxations in the
assembler and the linker shouldn't prevent leb128 support, all one needs for
linker relaxations is ULEB128 and SLEB128 relocation that allows subtraction of
two symbols. But what do you do for non-LEB128 symbol subtractions? Do you
have relocations for lab1 - lab2 if one has .quad lab1 - lab2 + 15 ?
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support
[not found] <bug-91602-4@http.gcc.gnu.org/bugzilla/>
2021-07-16 8:06 ` [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support belyshev at depni dot sinp.msu.ru
2021-07-16 8:24 ` jakub at gcc dot gnu.org
@ 2021-07-19 14:40 ` wilson at gcc dot gnu.org
2021-07-21 14:59 ` belyshev at depni dot sinp.msu.ru
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: wilson at gcc dot gnu.org @ 2021-07-19 14:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91602
--- Comment #14 from Jim Wilson <wilson at gcc dot gnu.org> ---
I posted a patch but didn't get a review, and then got distracted by other
stuff and failed to follow up.
https://gcc.gnu.org/pipermail/gcc-patches/2020-January/539461.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support
[not found] <bug-91602-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-07-19 14:40 ` wilson at gcc dot gnu.org
@ 2021-07-21 14:59 ` belyshev at depni dot sinp.msu.ru
2021-08-20 21:29 ` cvs-commit at gcc dot gnu.org
2021-08-20 21:34 ` belyshev at depni dot sinp.msu.ru
5 siblings, 0 replies; 6+ messages in thread
From: belyshev at depni dot sinp.msu.ru @ 2021-07-21 14:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91602
Serge Belyshev <belyshev at depni dot sinp.msu.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
--- Comment #15 from Serge Belyshev <belyshev at depni dot sinp.msu.ru> ---
(In reply to Serge Belyshev from comment #12)
> Testing a patch that removes in-tree gas version checks along with resulting
> dead code.
Patch posted: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575744.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support
[not found] <bug-91602-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-07-21 14:59 ` belyshev at depni dot sinp.msu.ru
@ 2021-08-20 21:29 ` cvs-commit at gcc dot gnu.org
2021-08-20 21:34 ` belyshev at depni dot sinp.msu.ru
5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-20 21:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91602
--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Sergey Belyshev <ssb@gcc.gnu.org>:
https://gcc.gnu.org/g:7cad8a8f9f7bfa8e98f6a0615541f589fd1d3fc1
commit r12-3047-g7cad8a8f9f7bfa8e98f6a0615541f589fd1d3fc1
Author: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Date: Fri Jul 16 10:52:33 2021 +0300
configure: drop version checks for in-tree gas [PR91602]
Special-casing checks for in-tree gas features is unnecessary since
r100007 which made configure-gcc depend on all-gas, and thus making
alternate code path in gcc_GAS_CHECK_FEATURE for in-tree gas
redundant.
Along the way this fixes PR 91602, which is caused by incorrect guess
of leb128 support presence in RISC-V.
First patch removes alternate code path in gcc_GAS_CHECK_FEATURE and
related code, the rest are further cleanups. Patches 2 and 3 in
series make no functional changes, thus configure is unchanged.
gcc/ChangeLog:
PR target/91602
* acinclude.m4 (_gcc_COMPUTE_GAS_VERSION,
_gcc_GAS_VERSION_GTE_IFELSE)
(gcc_GAS_VERSION_GTE_IFELSE): Remove.
(gcc_GAS_CHECK_FEATURE): Do not handle in-tree case specially.
* configure.ac: Remove gcc_cv_gas_major_version,
gcc_cv_gas_minor_version.
Remove remaining checks for in-tree assembler.
* configure: Regenerate.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/91602] GCC fails to build for riscv in a combined tree due to misconfigured leb128 support
[not found] <bug-91602-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2021-08-20 21:29 ` cvs-commit at gcc dot gnu.org
@ 2021-08-20 21:34 ` belyshev at depni dot sinp.msu.ru
5 siblings, 0 replies; 6+ messages in thread
From: belyshev at depni dot sinp.msu.ru @ 2021-08-20 21:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91602
Serge Belyshev <belyshev at depni dot sinp.msu.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |12.0
--- Comment #17 from Serge Belyshev <belyshev at depni dot sinp.msu.ru> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread