public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug d/91628] libdruntime uses glibc internal symbol on s390
       [not found] <bug-91628-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-24 15:51 ` ibuclaw at gdcproject dot org
  2020-03-24 16:20 ` ibuclaw at gdcproject dot org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 4+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-03-24 15:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628

--- Comment #17 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
I have no strong preferences, if people are wanting to go with the .S file,
then that's fine by me, feel free to commit (or I will if you'd prefer).

I'm just noting that I've seen a patch to implement musl support on s390x. 
Looks like there'll be nothing conflicting though.

https://gcc.gnu.org/legacy-ml/gcc-patches/2020-01/msg01806.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug d/91628] libdruntime uses glibc internal symbol on s390
       [not found] <bug-91628-4@http.gcc.gnu.org/bugzilla/>
  2020-03-24 15:51 ` [Bug d/91628] libdruntime uses glibc internal symbol on s390 ibuclaw at gdcproject dot org
@ 2020-03-24 16:20 ` ibuclaw at gdcproject dot org
  2020-04-08  8:15 ` stli at linux dot ibm.com
  2020-04-08  8:20 ` krebbel at gcc dot gnu.org
  3 siblings, 0 replies; 4+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-03-24 16:20 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628

--- Comment #18 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to Iain Buclaw from comment #17)
> I have no strong preferences, if people are wanting to go with the .S file,
> then that's fine by me, feel free to commit (or I will if you'd prefer).
> 

It would be better to prefix the name with double underscores, as it is an
internal symbol to D runtime.

CSYM(__ibmz_get_tls_offset):

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug d/91628] libdruntime uses glibc internal symbol on s390
       [not found] <bug-91628-4@http.gcc.gnu.org/bugzilla/>
  2020-03-24 15:51 ` [Bug d/91628] libdruntime uses glibc internal symbol on s390 ibuclaw at gdcproject dot org
  2020-03-24 16:20 ` ibuclaw at gdcproject dot org
@ 2020-04-08  8:15 ` stli at linux dot ibm.com
  2020-04-08  8:20 ` krebbel at gcc dot gnu.org
  3 siblings, 0 replies; 4+ messages in thread
From: stli at linux dot ibm.com @ 2020-04-08  8:15 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628

--- Comment #19 from stli at linux dot ibm.com <stli at linux dot ibm.com> ---
Fixed with gcc commit "S/390: Fix PR91628"
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=88e508f9f112acd07d0c49c53589160db8c85fcd

If somebody is backporting this fix, please also backport
gcc commit "S/390: Fix layout of struct sigaction_t"
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=434fe1a4092e12e5b518ef0716dc5b315e06118d

Otherwise you'll still see tls testsuite FAILs.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug d/91628] libdruntime uses glibc internal symbol on s390
       [not found] <bug-91628-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2020-04-08  8:15 ` stli at linux dot ibm.com
@ 2020-04-08  8:20 ` krebbel at gcc dot gnu.org
  3 siblings, 0 replies; 4+ messages in thread
From: krebbel at gcc dot gnu.org @ 2020-04-08  8:20 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628

Andreas Krebbel <krebbel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krebbel at gcc dot gnu.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #20 from Andreas Krebbel <krebbel at gcc dot gnu.org> ---
Fixed per previous comment.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-08  8:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-91628-4@http.gcc.gnu.org/bugzilla/>
2020-03-24 15:51 ` [Bug d/91628] libdruntime uses glibc internal symbol on s390 ibuclaw at gdcproject dot org
2020-03-24 16:20 ` ibuclaw at gdcproject dot org
2020-04-08  8:15 ` stli at linux dot ibm.com
2020-04-08  8:20 ` krebbel at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).