From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 8FECD398B865; Fri, 16 Apr 2021 18:50:23 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FECD398B865
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/91710] [9/10/11 Regression] unexpected ABI change note
 since r9-5650
Date: Fri, 16 Apr 2021 18:50:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 9.2.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-91710-4-65j3P9Zf6b@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-91710-4@http.gcc.gnu.org/bugzilla/>
References: <bug-91710-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2021 18:50:23 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D91710

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:49813aad3292f7f2bef69206274da78a9a7116ed

commit r11-8226-g49813aad3292f7f2bef69206274da78a9a7116ed
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Apr 16 20:49:33 2021 +0200

    aarch64: Don't emit -Wpsabi note when ABI was never affected [PR91710]

    As the following testcase shows, we emit a -Wpsabi note about argument
    passing change since GCC 9, but in reality the ABI didn't change.
    The alignment is 8 bits in GCC < 9 and 32 bits in GCC >=3D 9 and
    the aarch64_function_arg_alignment returns in that case:
    return MIN (MAX (alignment, PARM_BOUNDARY), STACK_BOUNDARY);
    so when both the old and new alignment are smaller or equal to
PARM_BOUNDARY
    (or both are larger than STACK_BOUNDARY, just in theory), even when the=
 new
    one is bigger, it doesn't change the argument passing.

    So, the following patch changes aarch64_function_arg_alignment to tell =
the
    callers the exact old alignmentm so that they can test it if needed.
    The other aarch64_function_arg_alignment callers either check the
    alignment for equality against 16-byte alignment (when old alignment was
    smaller than that and the new one is 16-byte, we want to emit -Wpsabi
    in all the cases) or the va_arg case which I think is ok now too.

    2021-04-16  Jakub Jelinek  <jakub@redhat.com>

            PR target/91710
            * config/aarch64/aarch64.c (aarch64_function_arg_alignment): Ch=
ange
            abi_break argument from bool * to unsigned *, store there the
pre-GCC 9
            alignment.
            (aarch64_layout_arg, aarch64_gimplify_va_arg_expr): Adjust call=
ers.
            (aarch64_function_arg_regno_p): Likewise.  Only emit -Wpsabi no=
te
if
            the old and new alignment after applying MIN/MAX to it is
different.

            * gcc.target/aarch64/pr91710.c: New test.=