public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug preprocessor/91733] No longer treat carriage return as an end-of-line
Date: Fri, 08 Jul 2022 14:04:42 +0000	[thread overview]
Message-ID: <bug-91733-4-smxwwaJ0kX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91733-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91733

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Lewis Hyatt <lhyatt@gcc.gnu.org>:

https://gcc.gnu.org/g:2bd15617e73acf76207127e5580cd10b1fab91a5

commit r13-1577-g2bd15617e73acf76207127e5580cd10b1fab91a5
Author: Lewis Hyatt <lhyatt@gmail.com>
Date:   Thu Jul 7 13:59:27 2022 -0400

    diagnostics: Make line-ending logic consistent with libcpp [PR91733]

    libcpp recognizes a lone \r as a valid line ending, so the infrastructure
    for retrieving source lines to be output in diagnostics needs to do the
    same. This patch fixes file_cache_slot::get_next_line() accordingly so that
    diagnostics display the correct part of the source when \r line endings are
in
    use.

    gcc/ChangeLog:

            PR preprocessor/91733
            * input.cc (find_end_of_line): New helper function.
            (file_cache_slot::get_next_line): Recognize \r as a line ending.
            * diagnostic-show-locus.cc (test_escaping_bytes_1): Adapt selftest
            since \r will now be interpreted as a line-ending.

    gcc/testsuite/ChangeLog:

            PR preprocessor/91733
            * c-c++-common/pr91733.c: New test.

  parent reply	other threads:[~2022-07-08 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-91733-4@http.gcc.gnu.org/bugzilla/>
2022-07-08  1:58 ` lhyatt at gcc dot gnu.org
2022-07-08 14:04 ` cvs-commit at gcc dot gnu.org [this message]
2022-07-08 14:06 ` lhyatt at gcc dot gnu.org
2022-07-08 14:27 ` akim.demaille at gmail dot com
2022-07-10 15:25 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-91733-4-smxwwaJ0kX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).