public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bergner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/91804] [10/11/12/13/14 regression] r265398 breaks gcc.target/powerpc/vec-rlmi-rlnm.c
Date: Tue, 20 Jun 2023 19:37:46 +0000	[thread overview]
Message-ID: <bug-91804-4-WlLFL4ulGf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91804-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91804

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |pthaugen at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #9 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Ajit Kumar Agarwal from comment #8)
> I don't see extra xxlor with latest gcc trunk. I think this is fixed.
> I think we should close this PR.

Thanks for looking Ajit.  I did a git bisect and it flagged a patch from Pat as
fixing this:

commit 51d89e61f7ebfe75ca752e62bd29b58cb957235c
Author:     Pat Haugen <pthaugen@linux.ibm.com>
AuthorDate: Mon May 10 13:49:06 2021 -0500
Commit:     Pat Haugen <pthaugen@linux.ibm.com>
CommitDate: Mon May 10 13:49:06 2021 -0500

    Add ALTIVEC_REGS as pressure class.

    Code that has heavy register pressure on Altivec registers can suffer from
    over-aggressive scheduling during sched1, which then leads to increased
    register spill. This is due to the fact that registers that prefer
    ALTIVEC_REGS are currently assigned an allocno class of VSX_REGS. This then
    misleads the scheduler to think there are 64 regs available, when in
reality
    there are only 32 Altivec regs. This patch fixes the problem by assigning
an
    allocno class of ALTIVEC_REGS and adding ALTIVEC_REGS as a pressure class.

    2021-05-10  Pat Haugen  <pthaugen@linux.ibm.com>

    gcc/ChangeLog:

            * config/rs6000/rs6000.c (rs6000_ira_change_pseudo_allocno_class):
            Return ALTIVEC_REGS if that is best_class.
            (rs6000_compute_pressure_classes): Add ALTIVEC_REGS.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/fold-vec-insert-float-p9.c: Adjust counts.
            * gcc.target/powerpc/vec-rlmi-rlnm.c: Likewise.

      parent reply	other threads:[~2023-06-20 19:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-91804-4@http.gcc.gnu.org/bugzilla/>
2020-04-01 18:11 ` [Bug target/91804] [10 " segher at gcc dot gnu.org
2020-04-01 19:49 ` bergner at gcc dot gnu.org
2020-04-08 23:03 ` wschmidt at gcc dot gnu.org
2020-05-07 11:56 ` [Bug target/91804] [10/11 " jakub at gcc dot gnu.org
2020-07-23  6:51 ` rguenth at gcc dot gnu.org
2021-04-08 12:02 ` rguenth at gcc dot gnu.org
2022-06-28 10:38 ` [Bug target/91804] [10/11/12/13 " jakub at gcc dot gnu.org
2023-06-20  9:04 ` [Bug target/91804] [10/11/12/13/14 " aagarwa at gcc dot gnu.org
2023-06-20 19:37 ` bergner at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-91804-4-WlLFL4ulGf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).