public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/91966] [8/9 Regression] pack expansion for Cartesian product  breaks if certain indirections are involved since r6-1487-g1a4cd2cd7e7266b0
Date: Fri, 03 Apr 2020 19:26:42 +0000	[thread overview]
Message-ID: <bug-91966-4-tQVO4D4Rxv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91966-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91966

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:70ae61692245b5002f32454c8447655ad65a8535

commit r9-8450-g70ae61692245b5002f32454c8447655ad65a8535
Author: Jason Merrill <jason@redhat.com>
Date:   Thu Apr 2 23:40:46 2020 -0400

    c++: alias template and parameter packs (PR91966).

    In this testcase, when we do a pack expansion of count_better_mins<nums>,
    nums appears both in the definition of count_better_mins and as its
template
    argument.  The intent is that we get a expansion over pairs of elements of
    the pack, i.e. less<2,2>, less<2,7>, less<7,2>, ....  But if we substitute
    into the definition of count_better_mins when parsing the template, we end
    up with sum<less<nums,nums>...>, which never gives us less<2,7>.  We could
    deal with this by somehow marking up the use of 'nums' as an argument for
    'num', but it's simpler to mark the alias as complex, so we need to
    instantiate it later with all its arguments rather than replace it early
    with its expansion.

    gcc/cp/ChangeLog
    2020-04-03  Jason Merrill  <jason@redhat.com>

            PR c++/91966
            * pt.c (complex_pack_expansion_r): New.
            (complex_alias_template_p): Use it.

  parent reply	other threads:[~2020-04-03 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-91966-4@http.gcc.gnu.org/bugzilla/>
2020-03-14  0:43 ` [Bug c++/91966] [8/9/10 " jason at gcc dot gnu.org
2020-04-03 17:49 ` cvs-commit at gcc dot gnu.org
2020-04-03 19:26 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-03 20:06 ` [Bug c++/91966] [8 " jason at gcc dot gnu.org
2020-04-04 22:35 ` cvs-commit at gcc dot gnu.org
2021-05-14 13:19 ` jakub at gcc dot gnu.org
2021-08-17  1:01 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-91966-4-tQVO4D4Rxv@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).