public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/91972] Bootstrap should use -Wmissing-declarations
Date: Tue, 05 May 2020 14:01:14 +0000 [thread overview]
Message-ID: <bug-91972-4-rUyOJ44alU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91972-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91972
--- Comment #4 from Alexander Monakov <amonakov at gcc dot gnu.org> ---
> Why is it missing the static keyword then? (Or alternatively, why isn't it in an anonymous namespace?)
Huh? Without the warning developers may simply forget to put the 'static'
keyword. With the warning they would be reminded when bootstrapping the patch.
> Ah, I like the namespace thing for target hooks (possibly langhooks as well).
Sure, it's nice to have sensible namespace rules for future additions, but
hopefully that's not a reason/excuse to never re-enable the warning.
next prev parent reply other threads:[~2020-05-05 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-91972-4@http.gcc.gnu.org/bugzilla/>
2020-05-05 9:42 ` amonakov at gcc dot gnu.org
2020-05-05 13:24 ` redi at gcc dot gnu.org
2020-05-05 13:34 ` rguenth at gcc dot gnu.org
2020-05-05 14:01 ` amonakov at gcc dot gnu.org [this message]
2020-06-08 1:55 ` egallager at gcc dot gnu.org
2021-11-30 7:18 ` egallager at gcc dot gnu.org
2021-11-30 10:38 ` amonakov at gcc dot gnu.org
2021-11-30 11:48 ` egallager at gcc dot gnu.org
2023-09-10 15:34 ` egallager at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-91972-4-rUyOJ44alU@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).