From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 26459388F06C; Tue,  5 May 2020 14:01:14 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26459388F06C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1588687274;
 bh=ZBx7MoKiIQFFPP28i/47XD9QeyBN3upwV2xyqmtMbj4=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=LqKbethPVoY6W6gD9KxuTUIuKp8p+1hwXB8XrbRd6zivHp81fqo+HX8J+NVSVboig
 v9dUokz/TJR3i1wnO20xMfCJzg60PBQBsgyjOMDeaZj1rlaaF3ul7DYKET13nDhiYN
 /R/5s4ePEC5iTvb5fOAy95ksJGAjUndz9iB3p/74=
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/91972] Bootstrap should use -Wmissing-declarations
Date: Tue, 05 May 2020 14:01:14 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 10.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: amonakov at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-91972-4-rUyOJ44alU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-91972-4@http.gcc.gnu.org/bugzilla/>
References: <bug-91972-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2020 14:01:14 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D91972

--- Comment #4 from Alexander Monakov <amonakov at gcc dot gnu.org> ---
> Why is it missing the static keyword then? (Or alternatively, why isn't i=
t in an anonymous namespace?)

Huh? Without the warning developers may simply forget to put the 'static'
keyword. With the warning they would be reminded when bootstrapping the pat=
ch.


> Ah, I like the namespace thing for target hooks (possibly langhooks as we=
ll).

Sure, it's nice to have sensible namespace rules for future additions, but
hopefully that's not a reason/excuse to never re-enable the warning.=